linux-kernel - Re: [PATCH v2 07/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250924100040.GA9827@pendragon.ideasonboard.com>
Date: Wed, 24 Sep 2025 13:00:40 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-media@...r.kernel.org, netdev@...r.kernel.org,
	linux-spi@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Javier Carrasco <javier.carrasco@...fvision.net>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Matthias Fend <matthias.fend@...end.at>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Paul Elder <paul.elder@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Mark Brown <broonie@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 07/16] property: Drop DEVICE_DISABLED flag in
 fwnode_graph_get_endpoint_count()

On Wed, Sep 24, 2025 at 10:45:53AM +0300, Sakari Ailus wrote:
> FWNODE_GRAPH_DEVICE_DISABLED flag isn't used anywhere, drop the flag and
> support for it in fwnode_graph_get_endpoint_count().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

With 06/16 squashed into this,

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  drivers/base/property.c  | 10 ++--------
>  include/linux/property.h |  8 +-------
>  2 files changed, 3 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 7fc3257f223d..4bd64e729431 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -1291,21 +1291,15 @@ EXPORT_SYMBOL_GPL(fwnode_graph_get_endpoint_by_id);
>  /**
>   * fwnode_graph_get_endpoint_count - Count endpoints on a device node
>   * @fwnode: The node related to a device
> - * @flags: fwnode lookup flags
>   * Count endpoints in a device node.
> - *
> - * If FWNODE_GRAPH_DEVICE_DISABLED flag is specified, also unconnected endpoints
> - * and endpoints connected to disabled devices are counted.
>   */
> -unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode,
> -					     unsigned long flags)
> +unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode)
>  {
>  	struct fwnode_handle *ep;
>  	unsigned int count = 0;
>  
>  	fwnode_graph_for_each_endpoint(fwnode, ep) {
> -		if (flags & FWNODE_GRAPH_DEVICE_DISABLED ||
> -		    fwnode_graph_remote_available(ep))
> +		if (fwnode_graph_remote_available(ep))
>  			count++;
>  	}
>  
> diff --git a/include/linux/property.h b/include/linux/property.h
> index d1e80b3c9918..8b8bbbe6b5b7 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -503,19 +503,13 @@ static inline bool fwnode_graph_is_endpoint(const struct fwnode_handle *fwnode)
>   * @FWNODE_GRAPH_ENDPOINT_NEXT: In the case of no exact match, look for the
>   *				closest endpoint ID greater than the specified
>   *				one.
> - * @FWNODE_GRAPH_DEVICE_DISABLED: That the device to which the remote
> - *				  endpoint of the given endpoint belongs to,
> - *				  may be disabled, or that the endpoint is not
> - *				  connected.
>   */
>  #define FWNODE_GRAPH_ENDPOINT_NEXT	BIT(0)
> -#define FWNODE_GRAPH_DEVICE_DISABLED	BIT(1)
>  
>  struct fwnode_handle *
>  fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
>  				u32 port, u32 endpoint, unsigned long flags);
> -unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode,
> -					     unsigned long flags);
> +unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode);
>  
>  #define fwnode_graph_for_each_endpoint(fwnode, child)				\
>  	for (child = fwnode_graph_get_next_endpoint(fwnode, NULL); child;	\

-- 
Regards,

Laurent Pinchart