linux-kernel - Re: [PATCH v2 14/16] leds: Use fwnode_get_next_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250924100317.GL28073@pendragon.ideasonboard.com>
Date: Wed, 24 Sep 2025 13:03:17 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-media@...r.kernel.org, netdev@...r.kernel.org,
	linux-spi@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Javier Carrasco <javier.carrasco@...fvision.net>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Matthias Fend <matthias.fend@...end.at>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Paul Elder <paul.elder@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Mark Brown <broonie@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 14/16] leds: Use fwnode_get_next_child_node() instead

On Wed, Sep 24, 2025 at 10:46:00AM +0300, Sakari Ailus wrote:
> fwnode_get_next_child_node() is now the same as
> fwnode_get_next_available_child_node() on all backends (OF, ACPI and
> swnode). In order to remove the available variants, switch the uses to
> non-available variants (device_get_next_child_node() in this case).
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  drivers/leds/flash/leds-rt4505.c   | 2 +-
>  drivers/leds/flash/leds-rt8515.c   | 2 +-
>  drivers/leds/flash/leds-sgm3140.c  | 3 +--
>  drivers/leds/flash/leds-tps6131x.c | 2 +-
>  4 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/leds/flash/leds-rt4505.c b/drivers/leds/flash/leds-rt4505.c
> index f16358b8dfc1..18fd5b7e528f 100644
> --- a/drivers/leds/flash/leds-rt4505.c
> +++ b/drivers/leds/flash/leds-rt4505.c
> @@ -365,7 +365,7 @@ static int rt4505_probe(struct i2c_client *client)
>  		return ret;
>  	}
>  
> -	child = fwnode_get_next_available_child_node(client->dev.fwnode, NULL);
> +	child = device_get_next_child_node(&client->dev, NULL);
>  	if (!child) {
>  		dev_err(priv->dev, "Failed to get child node\n");
>  		return -EINVAL;
> diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8515.c
> index 6af0d2c7fc56..f6b439674c03 100644
> --- a/drivers/leds/flash/leds-rt8515.c
> +++ b/drivers/leds/flash/leds-rt8515.c
> @@ -304,7 +304,7 @@ static int rt8515_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, PTR_ERR(rt->enable_torch),
>  				     "cannot get ENT (enable torch) GPIO\n");
>  
> -	child = fwnode_get_next_available_child_node(dev->fwnode, NULL);
> +	child = device_get_next_child_node(dev, NULL);
>  	if (!child) {
>  		dev_err(dev,
>  			"No fwnode child node found for connected LED.\n");
> diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
> index 3e83200675f2..dc6840357370 100644
> --- a/drivers/leds/flash/leds-sgm3140.c
> +++ b/drivers/leds/flash/leds-sgm3140.c
> @@ -214,8 +214,7 @@ static int sgm3140_probe(struct platform_device *pdev)
>  		return dev_err_probe(&pdev->dev, ret,
>  				     "Failed to request regulator\n");
>  
> -	child_node = fwnode_get_next_available_child_node(pdev->dev.fwnode,
> -							  NULL);
> +	child_node = device_get_next_child_node(&pdev->dev, NULL);
>  	if (!child_node) {
>  		dev_err(&pdev->dev,
>  			"No fwnode child node found for connected LED.\n");
> diff --git a/drivers/leds/flash/leds-tps6131x.c b/drivers/leds/flash/leds-tps6131x.c
> index 6f4d4fd55361..f0f1f2b77d5a 100644
> --- a/drivers/leds/flash/leds-tps6131x.c
> +++ b/drivers/leds/flash/leds-tps6131x.c
> @@ -544,7 +544,7 @@ static int tps6131x_parse_node(struct tps6131x *tps6131x)
>  
>  	tps6131x->valley_current_limit = device_property_read_bool(dev, "ti,valley-current-limit");
>  
> -	tps6131x->led_node = fwnode_get_next_available_child_node(dev->fwnode, NULL);
> +	tps6131x->led_node = device_get_next_child_node(dev, NULL);
>  	if (!tps6131x->led_node) {
>  		dev_err(dev, "Missing LED node\n");
>  		return -EINVAL;

-- 
Regards,

Laurent Pinchart