linux-kernel - [PATCH Next] copy_mnt_ns(): Remove unnecessary unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_2396E4374C4AA47497768767963CAD360E09@qq.com>
Date: Wed, 24 Sep 2025 18:29:04 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+0d671007a95cd2835e05@...kaller.appspotmail.com
Cc: brauner@...nel.org,
	jack@...e.cz,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com,
	viro@...iv.linux.org.uk
Subject: [PATCH Next] copy_mnt_ns(): Remove unnecessary unlock

This code segment is already protected by guards, namespace_unlock()
should not appear here.

Reported-by: syzbot+0d671007a95cd2835e05@...kaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=0d671007a95cd2835e05
Signed-off-by: Edward Adam Davis <eadavis@...com>
---
 fs/namespace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index ac1aedafe05e..c22febeda1ac 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -4134,7 +4134,6 @@ struct mnt_namespace *copy_mnt_ns(u64 flags, struct mnt_namespace *ns,
 	new = copy_tree(old, old->mnt.mnt_root, copy_flags);
 	if (IS_ERR(new)) {
 		emptied_ns = new_ns;
-		namespace_unlock();
 		return ERR_CAST(new);
 	}
 	if (user_ns != ns->user_ns) {
-- 
2.43.0