linux-kernel - Re: [PATCH v2] mm/memblock: Correct totalram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f0366c8-f05e-4687-817f-90a5b47922c9@web.de>
Date: Wed, 24 Sep 2025 15:23:26 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Alexander Potapenko <glider@...gle.com>, linux-mm@...ck.org,
 kasan-dev@...glegroups.com
Cc: LKML <linux-kernel@...r.kernel.org>, Aleksandr Nogikh
 <nogikh@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>, Dmitry Vyukov <dvyukov@...gle.com>,
 Marco Elver <elver@...gle.com>, Mike Rapoport <rppt@...nel.org>,
 Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH v2] mm/memblock: Correct totalram_pages accounting with
 KMSAN

…
> +++ b/mm/mm_init.c
> @@ -2548,24 +2548,25 @@ void *__init alloc_large_system_hash(const char *tablename,
…
> +unsigned long __init memblock_free_pages(struct page *page, unsigned long pfn,
> +					 unsigned int order)
>  {
…
>  	if (!kmsan_memblock_free_pages(page, order)) {
>  		/* KMSAN will take care of these pages. */
> -		return;
> +		return 0;
>  	}
…

How do you think about to omit curly brackets for this if statement?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc7#n197

Regards,
Markus