linux-kernel - Re: [PATCH next] RDMA/irdma: Fix positive vs negative error codes in irdma_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250924135624.GA2674496@nvidia.com>
Date: Wed, 24 Sep 2025 10:56:24 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Faisal Latif <faisal.latif@...el.com>,
	Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
	Leon Romanovsky <leon@...nel.org>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] RDMA/irdma: Fix positive vs negative error codes in
 irdma_post_send()

On Tue, Sep 23, 2025 at 02:20:45PM +0300, Dan Carpenter wrote:
> This code accidentally returns positive EINVAL instead of negative
> -EINVAL.  Some of the callers treat positive returns as success.
> Add the missing '-' char.
> 
> Fixes: a24a29c8747f ("RDMA/irdma: Add Atomic Operations support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/infiniband/hw/irdma/verbs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-next, thanks

Jason