linux-kernel - Re: [PATCH 2/4] hwmon: (dell-smm) Move clamping of fan speed out of i8k_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <964da8dd-449f-42bb-90df-5ecf4b2d1e32@roeck-us.net>
Date: Wed, 24 Sep 2025 07:47:28 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Armin Wolf <W_Armin@....de>
Cc: pali@...nel.org, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] hwmon: (dell-smm) Move clamping of fan speed out of
 i8k_set_fan()

On Wed, Sep 17, 2025 at 08:10:34PM +0200, Armin Wolf wrote:
> Currently i8k_set_fan() clamps the fan speed before performing the
> SMM call to ensure that the speed is not negative and not greater than
> i8k_fan_max. This however is mostly unnecessary as the hwmon and
> thermal interfaces alread ensure this. Only the legacy ioctl interface
> does not ensure that the fan speed passed to i8k_set_fan() does meet
> the above criteria.
> 
> Move the clamping out of i8k_set_fan() and into the legacy ioctl
> handler to prepare for future changes.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>

Applied.

Guenter