linux-kernel - Re: [PATCH 2/2] rust: pci: display symbolic PCI vendor names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02809090-539e-433f-a13b-14bd17bafe54@nvidia.com>
Date: Wed, 24 Sep 2025 18:38:35 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, linux-pci@...r.kernel.org,
 rust-for-linux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] rust: pci: display symbolic PCI vendor names

On 9/24/25 6:33 PM, John Hubbard wrote:
> The Display implementation for Vendor was forwarding directly to Debug
> printing, resulting in raw hex values instead of PCI Vendor strings.
> 
> Improve things by doing a stringify!() call for each PCI Vendor item.
> This now prints symbolic names such as "NVIDIA", instead of
> "Vendor(0x10de)". It still falls back to Debug formatting for unknown
> class values.
> 
> Suggested-by: Danilo Krummrich <dakr@...nel.org>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
>  rust/kernel/pci/id.rs | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/rust/kernel/pci/id.rs b/rust/kernel/pci/id.rs
> index 6e081de30faf..63db4d5f5617 100644
> --- a/rust/kernel/pci/id.rs
> +++ b/rust/kernel/pci/id.rs
> @@ -135,6 +135,18 @@ impl Vendor {
>                  pub const $variant: Self = Self($binding as u16);
>              )+
>          }
> +
> +        impl fmt::Display for Vendor {
> +            #[inline]

That #[inline] snuck in somehow (it's not in Class), but it should
not be there, because this expands to many lines of implementation.

If there is a v2 I'll remove it, otherwise maybe we can just ask
the maintainer to snip out that line.

thanks,
John Hubbard

> +            fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> +                match self {
> +                    $(
> +                        &Self::$variant => write!(f, stringify!($variant)),
> +                    )+
> +                    _ => <Self as fmt::Debug>::fmt(self, f),
> +                }
> +            }
> +        }
>      };
>  }
>  
> @@ -160,13 +172,6 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
>      }
>  }
>  
> -impl fmt::Display for Vendor {
> -    #[inline]
> -    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> -        <Self as fmt::Debug>::fmt(self, f)
> -    }
> -}
> -
>  define_all_pci_classes! {
>      NOT_DEFINED                = bindings::PCI_CLASS_NOT_DEFINED,                // 0x000000
>      NOT_DEFINED_VGA            = bindings::PCI_CLASS_NOT_DEFINED_VGA,            // 0x000100