linux-kernel - Re: [PATCH 13/21] mm/page_alloc_test: unit test pindex helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509252146.WmdVQlgy-lkp@intel.com>
Date: Thu, 25 Sep 2025 21:36:47 +0800
From: kernel test robot <lkp@...el.com>
To: Brendan Jackman <jackmanb@...gle.com>,
	Andy Lutomirski <luto@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>,
	Johannes Weiner <hannes@...xchg.org>, Zi Yan <ziy@...dia.com>,
	Axel Rasmussen <axelrasmussen@...gle.com>,
	Yuanchu Xie <yuanchu@...gle.com>,
	Roman Gushchin <roman.gushchin@...ux.dev>
Cc: oe-kbuild-all@...ts.linux.dev, peterz@...radead.org, bp@...en8.de,
	dave.hansen@...ux.intel.com, mingo@...hat.com, tglx@...utronix.de,
	akpm@...ux-foundation.org, david@...hat.com, derkling@...gle.com,
	junaids@...gle.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, reijiw@...gle.com, rientjes@...gle.com,
	rppt@...nel.org, vbabka@...e.cz, x86@...nel.org,
	yosry.ahmed@...ux.dev
Subject: Re: [PATCH 13/21] mm/page_alloc_test: unit test pindex helpers

Hi Brendan,

kernel test robot noticed the following build errors:

[auto build test ERROR on bf2602a3cb2381fb1a04bf1c39a290518d2538d1]

url:    https://github.com/intel-lab-lkp/linux/commits/Brendan-Jackman/x86-mm-asi-Add-CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION/20250924-230633
base:   bf2602a3cb2381fb1a04bf1c39a290518d2538d1
patch link:    https://lore.kernel.org/r/20250924-b4-asi-page-alloc-v1-13-2d861768041f%40google.com
patch subject: [PATCH 13/21] mm/page_alloc_test: unit test pindex helpers
config: x86_64-buildonly-randconfig-006-20250925 (https://download.01.org/0day-ci/archive/20250925/202509252146.WmdVQlgy-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250925/202509252146.WmdVQlgy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509252146.WmdVQlgy-lkp@intel.com/

All errors (new ones prefixed by >>):

   mm/page_alloc_test.c: In function 'test_pindex_helpers':
>> mm/page_alloc_test.c:19:30: error: implicit declaration of function 'pcp_allowed_order' [-Wimplicit-function-declaration]
      19 |                         if (!pcp_allowed_order(order))
         |                              ^~~~~~~~~~~~~~~~~
>> mm/page_alloc_test.c:24:55: error: implicit declaration of function 'order_to_pindex' [-Wimplicit-function-declaration]
      24 |                                 unsigned int pindex = order_to_pindex(ft, order);
         |                                                       ^~~~~~~~~~~~~~~
>> mm/page_alloc_test.c:44:45: error: implicit declaration of function 'pindex_to_order'; did you mean 'next_order'? [-Wimplicit-function-declaration]
      44 |                                 got_order = pindex_to_order(pindex);
         |                                             ^~~~~~~~~~~~~~~
         |                                             next_order


vim +/pcp_allowed_order +19 mm/page_alloc_test.c

     8	
     9	/* This just checks for basic arithmetic errors. */
    10	static void test_pindex_helpers(struct kunit *test)
    11	{
    12		unsigned long bitmap[bitmap_size(NR_PCP_LISTS)];
    13	
    14		/* Bit means "pindex not yet used". */
    15		bitmap_fill(bitmap, NR_PCP_LISTS);
    16	
    17		for (unsigned int order = 0; order < NR_PAGE_ORDERS; order++) {
    18			for (unsigned int mt = 0; mt < MIGRATE_PCPTYPES; mt++)  {
  > 19				if (!pcp_allowed_order(order))
    20					continue;
    21	
    22				for (int sensitive = 0; sensitive < NR_SENSITIVITIES; sensitive++) {
    23					freetype_t ft = migrate_to_freetype(mt, sensitive);
  > 24					unsigned int pindex = order_to_pindex(ft, order);
    25					int got_order;
    26	
    27					KUNIT_ASSERT_LT_MSG(test, pindex, NR_PCP_LISTS,
    28						"invalid pindex %d (order %d mt %d sensitive %d)",
    29						pindex, order, mt, sensitive);
    30					KUNIT_EXPECT_TRUE_MSG(test, test_bit(pindex, bitmap),
    31						"pindex %d reused (order %d mt %d sensitive %d)",
    32						pindex, order, mt, sensitive);
    33	
    34					/*
    35					 * For THP, two migratetypes map to the
    36					 * same pindex, just manually exclude one
    37					 * of those cases.
    38					 */
    39					if (!(IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
    40					      order == HPAGE_PMD_ORDER &&
    41					      mt == min(MIGRATE_UNMOVABLE, MIGRATE_RECLAIMABLE)))
    42						clear_bit(pindex, bitmap);
    43	
  > 44					got_order = pindex_to_order(pindex);
    45					KUNIT_EXPECT_EQ_MSG(test, order, got_order,
    46						"roundtrip failed, got %d want %d (pindex %d mt %d sensitive %d)",
    47						got_order, order, pindex, mt, sensitive);
    48	
    49				}
    50			}
    51		}
    52	
    53		KUNIT_EXPECT_TRUE_MSG(test, bitmap_empty(bitmap, NR_PCP_LISTS),
    54			"unused pindices: %*pbl", NR_PCP_LISTS, bitmap);
    55	}
    56	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki