linux-kernel - Re: [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <977f1b63-1617-447a-8ef8-775662ad0827@linux.dev>
Date: Thu, 25 Sep 2025 14:44:24 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Dan Carpenter <dan.carpenter@...aro.org>, Ivan Vecera <ivecera@...hat.com>
Cc: Prathosh Satish <Prathosh.Satish@...rochip.com>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Jiri Pirko <jiri@...nulli.us>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 net-next] dpll: zl3073x: Fix double free in
 zl3073x_devlink_flash_update()

On 25/09/2025 14:28, Dan Carpenter wrote:
> The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() and
> the caller, zl3073x_devlink_flash_update(), also calls that same free
> function so it leads to a double free.  Delete the extra free.
> 

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>