[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <pd5zbxclxtrfaukorad6dyld5foa6tcupqeiraj6uxlio6tmdu@gklwmof7n6sd>
Date: Thu, 25 Sep 2025 09:06:17 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com,
yijie.yang@....qualcomm.com
Subject: Re: [PATCH 15/20] arm64: dts: qcom: kaanapali-mtp: Enable modem
On Wed, Sep 24, 2025 at 05:17:32PM -0700, Jingyi Wang wrote:
> Enable the MODEM on Kaanapali MTP board.
>
Please omit this until you have gotten it to work, and if that happens
before resubmitting "arm64: dts: qcom: kaanapali-mtp: Enable more
features" squash it into that.
PS. The patch adds a failed node, but the commit message doesn't
describe that, or mention that it is broken.
Thanks,
Bjorn
> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> index 2949579481a9..8d1b3278389e 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> @@ -1263,6 +1263,14 @@ &remoteproc_cdsp {
> status = "okay";
> };
>
> +&remoteproc_mpss {
> + firmware-name = "qcom/kaanapali/modem.mbn",
> + "qcom/kaanapali/modem_dtb.mbn";
> +
> + /* Modem crashes after some time for OEMPD load failure */
> + status = "fail";
> +};
> +
> &remoteproc_soccp {
> firmware-name = "qcom/kaanapali/soccp.mbn",
> "qcom/kaanapali/soccp_dtb.mbn";
>
> --
> 2.25.1
>
Powered by blists - more mailing lists