linux-kernel - Re: [PATCH v3] scsi: ufs: core: Fix data race in CPU latency PM QoS request handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1o6qzqol6.fsf@ca-mkp.ca.oracle.com>
Date: Wed, 24 Sep 2025 21:59:50 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
Cc: alim.akhtar@...sung.com, avri.altman@....com, bvanassche@....org,
        James.Bottomley@...senPartnership.com, martin.petersen@...cle.com,
        peter.wang@...iatek.com, tanghuan@...o.com, liu.song13@....com.cn,
        quic_nguyenb@...cinc.com, viro@...iv.linux.org.uk, huobean@...il.com,
        adrian.hunter@...el.com, can.guo@....qualcomm.com, ebiggers@...nel.org,
        neil.armstrong@...aro.org, angelogioacchino.delregno@...labora.com,
        quic_narepall@...cinc.com, quic_mnaresh@...cinc.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        nitin.rawat@....qualcomm.com, ziqi.chen@....qualcomm.com
Subject: Re: [PATCH v3] scsi: ufs: core: Fix data race in CPU latency PM QoS
 request handling


Zhongqiu,

> The cpu_latency_qos_add/remove/update_request interfaces lack internal
> synchronization by design, requiring the caller to ensure thread
> safety. The current implementation relies on the `pm_qos_enabled`
> flag, which is insufficient to prevent concurrent access and cannot
> serve as a proper synchronization mechanism. This has led to data
> races and list corruption issues.

Applied to 6.18/scsi-staging, thanks!

-- 
Martin K. Petersen