linux-kernel - Re: [PATCH v3 05/12] tools/nolibc: implement %m if errno is not defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8e4b65c-8d1d-49ac-8f33-00a46a8b9f11@t-8ch.de>
Date: Thu, 25 Sep 2025 18:24:02 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Benjamin Berg <benjamin@...solutions.net>
Cc: linux-um@...ts.infradead.org, Willy Tarreau <w@....eu>, 
	linux-kselftest@...r.kernel.org, Arnaldo Carvalho de Melo <acme@...hat.com>, 
	linux-kernel@...r.kernel.org, Benjamin Berg <benjamin.berg@...el.com>
Subject: Re: [PATCH v3 05/12] tools/nolibc: implement %m if errno is not
 defined

On 2025-09-24 16:20:52+0200, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@...el.com>
> 
> For improved compatibility, print %m as "unknown error" when nolibc is
> compiled using NOLIBC_IGNORE_ERRNO.
> 
> Signed-off-by: Benjamin Berg <benjamin.berg@...el.com>

Thanks for taking care of this.

Acked-by: Thomas Weißschuh <linux@...ssschuh.net>

> ---
>  tools/include/nolibc/stdio.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
> index 724d05ce6962..1f16dab2ac88 100644
> --- a/tools/include/nolibc/stdio.h
> +++ b/tools/include/nolibc/stdio.h
> @@ -321,11 +321,13 @@ int __nolibc_printf(__nolibc_printf_cb cb, intptr_t state, size_t n, const char
>  				if (!outstr)
>  					outstr="(null)";
>  			}
> -#ifndef NOLIBC_IGNORE_ERRNO
>  			else if (c == 'm') {
> +#ifdef NOLIBC_IGNORE_ERRNO
> +				outstr = "unknown error";
> +#else
>  				outstr = strerror(errno);
> -			}
>  #endif /* NOLIBC_IGNORE_ERRNO */
> +			}
>  			else if (c == '%') {
>  				/* queue it verbatim */
>  				continue;
> -- 
> 2.51.0
>