linux-kernel - Re: [PATCH] drm/display: add hw_params callback function to drm_connector_hdmi_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6mq5morx4kuwmxa3dhpxf42uqedtveectlbeodl5oj74rqk4gy@oweda3unauqj>
Date: Thu, 25 Sep 2025 05:18:07 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Jianfeng Liu <liujianfeng1994@...il.com>
Cc: airlied@...il.com, broonie@...nel.org, dri-devel@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        lumag@...nel.org, maarten.lankhorst@...ux.intel.com,
        mripard@...nel.org, quic_abhinavk@...cinc.com, simona@...ll.ch,
        sophon@...xa.com, tzimmermann@...e.de
Subject: Re: [PATCH] drm/display: add hw_params callback function to
 drm_connector_hdmi_audio_ops

On Thu, Sep 25, 2025 at 09:51:12AM +0800, Jianfeng Liu wrote:
> Hi,
> 
> On 2025-09-24 20:17 UTC, Dmitry Baryshkov wrote:
> >> msm_dp_audio_prepare is not called because hdmi-codec driver only checks
> >> and runs hw_params. This commit will add hw_params callback function
> >> same as drm_connector_hdmi_audio_prepare, so that hdmi-codec driver can
> >> work with userspace alsa.
> >
> >I think something is wrong here. The prepare callback also should be
> >called. Is it that the prepare callback is called too late?
> 
> I have added debug log to hdmi_codec_hw_params() and hdmi_codec_prepare(),
> but only logs from hdmi_codec_hw_params() are printed without this patch.
> After applying this patch, hdmi_codec_prepare() is called after
> hdmi_codec_hw_params():

When does q6apm_lpass_dai_prepare() happen?

> 
> [   14.218445] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_hw_params() started
> [   14.223004] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_prepare() started
> [   14.534614] msm_dpu ae01000.display-controller: [drm:adreno_request_fw] loaded qcom/a660_gmu.bin from new location
> [   14.535750] [drm] Loaded GMU firmware v3.1.10
> [   15.727443] rfkill: input handler disabled
> [   42.647157] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_hw_params() started
> [   42.656774] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_prepare() started
> 
> Best regards,
> Jianfeng

-- 
With best wishes
Dmitry