linux-kernel - Re: [PATCH v9 09/10] fs/resctrl: Introduce interface to modify io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6929b406-0de5-4dfe-a940-f2c8cb38cd60@amd.com>
Date: Thu, 25 Sep 2025 13:54:47 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, "Moger, Babu"
 <bmoger@....com>, corbet@....net, tony.luck@...el.com, Dave.Martin@....com,
 james.morse@....com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, kas@...nel.org,
 rick.p.edgecombe@...el.com, akpm@...ux-foundation.org, paulmck@...nel.org,
 pmladek@...e.com, pawan.kumar.gupta@...ux.intel.com, rostedt@...dmis.org,
 kees@...nel.org, arnd@...db.de, fvdl@...gle.com, seanjc@...gle.com,
 thomas.lendacky@....com, manali.shukla@....com, perry.yuan@....com,
 sohil.mehta@...el.com, xin@...or.com, peterz@...radead.org,
 mario.limonciello@....com, gautham.shenoy@....com, nikunj@....com,
 dapeng1.mi@...ux.intel.com, ak@...ux.intel.com, chang.seok.bae@...el.com,
 ebiggers@...gle.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev, kvm@...r.kernel.org
Subject: Re: [PATCH v9 09/10] fs/resctrl: Introduce interface to modify
 io_alloc Capacity Bit Masks

Hi Reinette,

On 9/22/25 17:48, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/19/25 1:49 PM, Moger, Babu wrote:
>  
>> Here is the updated full changelog.
>>
>> fs/resctrl: Introduce interface to modify io_alloc Capacity Bit Masks
> 
> I do not think it is necessary to use upper case if not following it
> by the acronym. I also think "bitmask" is usually one word? So:
> 	fs/resctrl: Introduce interface to modify io_alloc capacity bitmasks
> 

Sure.

>>
>> The io_alloc feature in resctrl enables system software to configure the
>> portion of the cache allocated for I/O traffic. When supported, the
>> io_alloc_cbm file in resctrl provides access to Capacity Bit Masks (CBMs) allocated for I/O devices.
>>
>> Enable users to modify io_alloc CBMs via io_alloc_cbm resctrl file when the feature is enabled.
> 
> (nit) can be made more specific with:
> 
> 	Enable users to modify io_alloc CBMs by writing to the io_alloc_cbm resctrl
> 	file when the io_alloc feature is enabled.
> 

Sure.

>>
>> Mirror the CBMs between CDP_CODE and CDP_DATA when CDP is enabled to present consistent I/O allocation information to user space and keep both resource types synchronized.
> 
> I think "and keep both resource types synchronized" is redundant considering the sentence
> starts with "Mirror the CBMs"?

Removed "and keep both resource types synchronized."
-- 
Thanks
Babu Moger