linux-kernel - Re: [PATCH 2/3 v2] PCI: s32g: Add initial PCIe support (RC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250925191520.GA2175949@bhelgaas>
Date: Thu, 25 Sep 2025 14:15:20 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Vincent Guittot <vincent.guittot@...aro.org>, chester62515@...il.com,
	mbrugger@...e.com, ghennadi.procopciuc@....nxp.com, s32@....com,
	bhelgaas@...gle.com, jingoohan1@...il.com, lpieralisi@...nel.org,
	kwilczynski@...nel.org, mani@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, Ionut.Vicovan@....com, larisa.grigore@....com,
	Ghennadi.Procopciuc@....com, ciprianmarian.costea@....com,
	bogdan.hamciuc@....com, Frank.li@....com,
	linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, cassel@...nel.org
Subject: Re: [PATCH 2/3 v2] PCI: s32g: Add initial PCIe support (RC)

On Mon, Sep 22, 2025 at 09:52:21AM -0500, Rob Herring wrote:
> On Fri, Sep 19, 2025 at 10:58 AM Vincent Guittot
> > Add initial support of the PCIe controller for S32G Soc family. Only
> > host mode is supported.

> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -255,6 +255,17 @@ config PCIE_TEGRA194_EP
> >           in order to enable device-specific features PCIE_TEGRA194_EP must be
> >           selected. This uses the DesignWare core.
> >
> > +config PCIE_S32G
> > +       bool "NXP S32G PCIe controller (host mode)"
> > +       depends on ARCH_S32 || (OF && COMPILE_TEST)
> 
> Why the OF dependency? All the DT API should be available with !CONFIG_OF.

We have lots of similar OF dependencies.  Do we really want it to be
possible to build a non-working driver in the !COMPILE_TEST case?

Maybe we should retain the OF dependency but only for !COMPILE_TEST,
like this:

  config PCIE_S32G
         depends on (ARCH_S32 && OF) || COMPILE_TEST