lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fd575fd2-f246-469d-9276-bb746b554e19@linuxfoundation.org>
Date: Thu, 25 Sep 2025 13:23:44 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Madhur Kumar <madhurkumar004@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 shuah@...nel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 1/2] selftests/acct: add cleanup for leftover
 process_log binary

On 9/25/25 02:34, Madhur Kumar wrote:
> Some kselftests generate temporary binaries that are not tracked
> by TEST_GEN_PROGS. Add EXTRA_CLEAN entry to remove process_log
> during `make kselftest-clean`.
> 

This information below doesn't belong in the change log

> v2:
> - Fix newline issue at end of Makefile (caused add/delete in git diff)
> - Code otherwise unchanged
> 
> Signed-off-by: Madhur Kumar <madhurkumar004@...il.com>
> ---

Add patch version information here.


>   tools/testing/selftests/acct/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/acct/Makefile b/tools/testing/selftests/acct/Makefile
> index 7e025099cf65..fd14128bbddb 100644
> --- a/tools/testing/selftests/acct/Makefile
> +++ b/tools/testing/selftests/acct/Makefile
> @@ -1,5 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   TEST_GEN_PROGS := acct_syscall
>   CFLAGS += -Wall
> +EXTRA_CLEAN := process_log
>   
>   include ../lib.mk

This line below is still odd.

> \ No newline at end of file

Start without any changes, make the change, commit, and send
v3. Refer to a few patches on the mailing list for examples
on where the patch version information should be added.

thanks,
-- Shuah


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ