linux-kernel - Re: [PATCH 1/3] mm/page_owner: add option 'print_handle' for 'show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250925202817.795114-1-joshua.hahnjy@gmail.com>
Date: Thu, 25 Sep 2025 13:28:16 -0700
From: Joshua Hahn <joshua.hahnjy@...il.com>
To: Mauricio Faria de Oliveira <mfo@...lia.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Oscar Salvador <osalvador@...e.de>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>,
	Brendan Jackman <jackmanb@...gle.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Zi Yan <ziy@...dia.com>,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	kernel-dev@...lia.com
Subject: Re: [PATCH 1/3] mm/page_owner: add option 'print_handle' for 'show_stacks'

On Wed, 24 Sep 2025 14:40:21 -0300 Mauricio Faria de Oliveira <mfo@...lia.com> wrote:

> For monitoring the memory usage per stack trace, it is more efficient to
> use the handle number as unique identifier of a stack trace than to, for
> example, read/hash all stack traces to uniquely identify them everytime.
> 
> The handle number is a unique identifier for stack traces in stackdepot.
> 
> This patch adds the option 'print_handle' to print the handle number of
> stack traces in 'show_stacks'.

> @@ -887,6 +887,7 @@ static void *stack_next(struct seq_file *m, void *v, loff_t *ppos)
>  }
>  
>  static unsigned long page_owner_pages_threshold;
> +static bool page_owner_print_handle;

Hi Mauricio,

Quick nit -- If I understand your cover letter correctly, you want
page_owner_print_handle to be false by default, should we initialize this
to false?

Have a great day!
Joshua

Sent using hkml (https://github.com/sjp38/hackermail)