linux-kernel - Re: [PATCH v2] clk: qcom: gcc-glymur: Update the halt check flags for pipe clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gprk7uhwqnj37cyl5iae64qrevkts3z266y2e5k6z72bcujhml@n5yaik3jtm2a>
Date: Fri, 26 Sep 2025 00:18:38 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Imran Shaik <imran.shaik@....qualcomm.com>
Cc: Taniya Das <taniya.das@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik <quic_imrashai@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clk: qcom: gcc-glymur: Update the halt check flags
 for pipe clocks

On Thu, Sep 25, 2025 at 07:10:47PM +0530, Imran Shaik wrote:
> 
> 
> On 9/25/2025 3:49 PM, Taniya Das wrote:
> > The pipe clocks for PCIE and USB are externally sourced and they should
> > not be polled by the clock driver. Update the halt_check flags to 'SKIP'
> > to disable polling for these clocks.
> > 
> > This helps avoid the clock status stuck at 'off' warnings, which are
> > benign, since all consumers of the PHYs must initialize a given instance
> > before performing any operations.
> > 
> > Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller")
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> > Signed-off-by: Taniya Das <taniya.das@....qualcomm.com>
> > ---
> > Changes in v2:
> > - Update the commit text to add the SoC name "glymur" [Konrad]
> > - Update the commit subject to add more details [Konrad]
> > - Add RB [Konrad]
> > - Fix a typo [Markus Elfring]
> > - Link to v1: https://lore.kernel.org/r/20250924-glymur_gcc_usb_fixes-v1-1-a90568723e64@oss.qualcomm.com
> > ---
> >  drivers/clk/qcom/gcc-glymur.c | 24 ++++++++++++------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> > Reviewed-by: Imran Shaik <imran.shaik@....qualcomm.com>

Note how you've responded. It will be ignored by all the tools. Please
send it correctly.

Anyway:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>



> 
> Thanks,
> Imran

-- 
With best wishes
Dmitry