linux-kernel - Re: [PATCH] net: phy: microchip_t1: LAN887X: Fix device init issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e2ea3a1-6c5e-4427-9b23-2c07da09088d@lunn.ch>
Date: Fri, 26 Sep 2025 00:00:26 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Josef Raschen <josef@...chen.org>
Cc: Arun Ramadoss <arun.ramadoss@...rochip.com>,
	UNGLinuxDriver@...rochip.com,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: microchip_t1: LAN887X: Fix device init issues.

On Thu, Sep 25, 2025 at 10:52:22PM +0200, Josef Raschen wrote:
> Currently, for a LAN8870 phy, before link up, a call to ethtool to set
> master-slave fails with 'operation not supported'. Reason: speed, duplex
> and master/slave are not properly initialized.
> 
> This change sets proper initial states for speed and duplex and publishes
> master-slave states. A default link up for speed 1000, full duplex and
> slave mode then works without having to call ethtool.

Hi Josef

What you are missing from the commit message is an explanation why the
LAN8870 is special, it needs to do something no other PHY does. Is
there something broken with this PHY? Some register not following
802.3?

    Andrew

---
pw-bot: cr