linux-kernel - Re: [PATCH v8] Bluetooth: mediatek: add gpio pin to reset bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509260623.nZX7ipvc-lkp@intel.com>
Date: Fri, 26 Sep 2025 06:55:01 +0800
From: kernel test robot <lkp@...el.com>
To: Zhangchao Zhang <ot_zhangchao.zhang@...iatek.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Luiz Von Dentz <luiz.dentz@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: oe-kbuild-all@...ts.linux.dev, Krzysztof Kozlowski <krzk@...nel.org>,
	Sean Wang <sean.wang@...iatek.com>,
	Deren Wu <deren.Wu@...iatek.com>, Chris Lu <chris.lu@...iatek.com>,
	Hao Qin <Hao.qin@...iatek.com>,
	linux-bluetooth <linux-bluetooth@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-mediatek <linux-mediatek@...ts.infradead.org>,
	Zhangchao Zhang <ot_zhangchao.zhang@...iatek.com>
Subject: Re: [PATCH v8] Bluetooth: mediatek: add gpio pin to reset bt

Hi Zhangchao,

kernel test robot noticed the following build errors:

[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.17-rc7 next-20250925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zhangchao-Zhang/Bluetooth-mediatek-add-gpio-pin-to-reset-bt/20250925-172508
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link:    https://lore.kernel.org/r/20250925092058.16648-1-ot_zhangchao.zhang%40mediatek.com
patch subject: [PATCH v8] Bluetooth: mediatek: add gpio pin to reset bt
config: sh-randconfig-001-20250926 (https://download.01.org/0day-ci/archive/20250926/202509260623.nZX7ipvc-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509260623.nZX7ipvc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509260623.nZX7ipvc-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/bluetooth/btusb.c: In function 'btusb_mtk_reset':
>> drivers/bluetooth/btusb.c:2769:19: error: 'struct btusb_data' has no member named 'rest_gpio'; did you mean 'reset_gpio'?
    2769 |         if (data->rest_gpio) {
         |                   ^~~~~~~~~
         |                   reset_gpio


vim +2769 drivers/bluetooth/btusb.c

  2740	
  2741	static int btusb_mtk_reset(struct hci_dev *hdev, void *rst_data)
  2742	{
  2743		struct btusb_data *data = hci_get_drvdata(hdev);
  2744		struct btmtk_data *btmtk_data = hci_get_priv(hdev);
  2745		int err;
  2746	
  2747		/* It's MediaTek specific bluetooth reset mechanism via USB */
  2748		if (test_and_set_bit(BTMTK_HW_RESET_ACTIVE, &btmtk_data->flags)) {
  2749			bt_dev_err(hdev, "last reset failed? Not resetting again");
  2750			return -EBUSY;
  2751		}
  2752	
  2753		err = usb_autopm_get_interface(data->intf);
  2754		if (err < 0)
  2755			return err;
  2756	
  2757		/* Release MediaTek ISO data interface */
  2758		btusb_mtk_release_iso_intf(hdev);
  2759	
  2760		btusb_stop_traffic(data);
  2761		usb_kill_anchored_urbs(&data->tx_anchor);
  2762	
  2763		/* Toggle the hard reset line. The MediaTek device is going to
  2764		 * yank itself off the USB and then replug. The cleanup is handled
  2765		 * correctly on the way out (standard USB disconnect), and the new
  2766		 * device is detected cleanly and bound to the driver again like
  2767		 * it should be.
  2768		 */
> 2769		if (data->rest_gpio) {
  2770			gpiod_set_value_cansleep(data->reset_gpio, 1);
  2771			msleep(200);
  2772			gpiod_set_value_cansleep(data->reset_gpio, 0);
  2773			return 0;
  2774		}
  2775	
  2776		err = btmtk_usb_subsys_reset(hdev, btmtk_data->dev_id);
  2777	
  2778		usb_queue_reset_device(data->intf);
  2779		clear_bit(BTMTK_HW_RESET_ACTIVE, &btmtk_data->flags);
  2780	
  2781		return err;
  2782	}
  2783	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki