linux-kernel - RE: [PATCH v2 10/10] nova-core: gsp: Boot GSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY5PR12MB65261F96A203E0FC76E78C89C21FA@CY5PR12MB6526.namprd12.prod.outlook.com>
Date: Thu, 25 Sep 2025 03:09:40 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Alistair Popple <apopple@...dia.com>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "dakr@...nel.org" <dakr@...nel.org>,
	Alexandre Courbot <acourbot@...dia.com>
CC: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
	<aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, John Hubbard <jhubbard@...dia.com>,
	Joel Fernandes <joelagnelf@...dia.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>
Subject: RE: [PATCH v2 10/10] nova-core: gsp: Boot GSP

> +        sec2_falcon.reset(bar)?;
> +        sec2_falcon.dma_load(bar, &booter_loader)?;
> +        let wpr_handle = wpr_meta.dma_handle();
> +        let (mbox0, mbox1) = sec2_falcon.boot(
> +            bar,
> +            Some(wpr_handle as u32),
> +            Some((wpr_handle >> 32) as u32),
> +        )?;
> +        dev_dbg!(
> +            pdev.as_ref(),
> +            "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n",
> +            mbox0,
> +            mbox1
> +        );

You should add something like this:

        if mbox0 != 0 {
            dev_err!(pdev.as_ref(), "Booter-load failed with error {:#x}\n", mbox0);
            return Err(ENODEV);
        }

Booter returns an error code in MBOX0, and it's very handy to display that code if it's non-zero.