linux-kernel - Re: [PATCH 1/3] dt-bindings: iio: pressure: add binding for mpl3115

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNS5lGpv6ezZ8HpZ@debian-BULLSEYE-live-builder-AMD64>
Date: Thu, 25 Sep 2025 00:40:04 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: Antoni Pokusinski <apokusinski01@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
	linux@...ck-us.net, rodrigo.gobbi.7@...il.com,
	naresh.solanki@...ements.com, michal.simek@....com,
	grantpeltier93@...il.com, farouk.bouabid@...rry.de
Subject: Re: [PATCH 1/3] dt-bindings: iio: pressure: add binding for mpl3115

Hi Antoni,

Some inline suggestions for making this binding better comply with the
'attempt to make bindings complete' guideline.

On 09/21, Antoni Pokusinski wrote:
> MPL3115 is an I2C pressure and temperature sensor. It features 2
> interrupt lines which can be configured to indicate events such as data
> ready or pressure/temperature threshold reached.
> 
> Signed-off-by: Antoni Pokusinski <apokusinski01@...il.com>
> ---
...
> +description: |
> +  MPL3115 is a pressure/altitude and temperature sensor with I2C interface.
> +  It features two programmable interrupt lines which indicate events such as
> +  data ready or pressure/temperature threshold reached.
> +  https://www.nxp.com/docs/en/data-sheet/MPL3115A2.pdf
> +
> +properties:
> +  compatible:
> +    const: fsl,mpl3115
> +
> +  reg:
> +    maxItems: 1

For completeness, could also add the power supplies.

  vdd-supply: true

  vddio-supply: true

> +
> +  interrupts:
> +    minItems: 1
> +    maxItems: 2
> +
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      enum:
> +        - INT1
> +        - INT2
> +
> +  drive-open-drain:
> +    type: boolean
> +    description:
> +      set if the specified interrupt pins should be configured as
> +      open drain. If not set, defaults to push-pull.
> +
> +required:
> +  - compatible
> +  - reg
  - vdd-supply
  - vddio-supply

and also add the supplies to the example below.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pressure@60 {
> +            compatible = "fsl,mpl3115";
> +            reg = <0x60>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> +            interrupt-names = "INT2";
> +        };
> +    };

Best regards,
Marcelo