linux-kernel - Re: [PATCH v2 1/2] nvmem: Add driver for the eeprom in qnap-mcu controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202509251340.DSObePVn-lkp@intel.com>
Date: Thu, 25 Sep 2025 14:03:40 +0800
From: kernel test robot <lkp@...el.com>
To: Heiko Stuebner <heiko@...ech.de>, lee@...nel.org, srini@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, heiko@...ech.de
Subject: Re: [PATCH v2 1/2] nvmem: Add driver for the eeprom in qnap-mcu
 controllers

Hi Heiko,

kernel test robot noticed the following build errors:

[auto build test ERROR on lee-leds/for-leds-next]
[also build test ERROR on lee-mfd/for-mfd-next linus/master lee-mfd/for-mfd-fixes v6.17-rc7 next-20250924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Heiko-Stuebner/nvmem-Add-driver-for-the-eeprom-in-qnap-mcu-controllers/20250923-212052
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link:    https://lore.kernel.org/r/20250923131815.1898332-2-heiko%40sntech.de
patch subject: [PATCH v2 1/2] nvmem: Add driver for the eeprom in qnap-mcu controllers
config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20250925/202509251340.DSObePVn-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project cafc064fc7a96b3979a023ddae1da2b499d6c954)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250925/202509251340.DSObePVn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509251340.DSObePVn-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from <built-in>:3:
   In file included from include/linux/compiler_types.h:171:
   include/linux/compiler-clang.h:28:9: warning: '__SANITIZE_ADDRESS__' macro redefined [-Wmacro-redefined]
      28 | #define __SANITIZE_ADDRESS__
         |         ^
   <built-in>:352:9: note: previous definition is here
     352 | #define __SANITIZE_ADDRESS__ 1
         |         ^
   In file included from drivers/nvmem/qnap-mcu-eeprom.c:12:
   include/linux/mfd/qnap-mcu.h:13:2: error: unknown type name 'u32'
      13 |         u32 baud_rate;
         |         ^
   include/linux/mfd/qnap-mcu.h:17:2: error: unknown type name 'bool'
      17 |         bool usb_led;
         |         ^
   include/linux/mfd/qnap-mcu.h:21:11: error: unknown type name 'u8'
      21 |                   const u8 *cmd_data, size_t cmd_data_size,
         |                         ^
   include/linux/mfd/qnap-mcu.h:21:25: error: unknown type name 'size_t'
      21 |                   const u8 *cmd_data, size_t cmd_data_size,
         |                                       ^
   include/linux/mfd/qnap-mcu.h:22:5: error: unknown type name 'u8'
      22 |                   u8 *reply_data, size_t reply_data_size);
         |                   ^
   include/linux/mfd/qnap-mcu.h:22:21: error: unknown type name 'size_t'
      22 |                   u8 *reply_data, size_t reply_data_size);
         |                                   ^
   include/linux/mfd/qnap-mcu.h:24:13: error: unknown type name 'u8'
      24 |                            const u8 *cmd_data, size_t cmd_data_size);
         |                                  ^
   include/linux/mfd/qnap-mcu.h:24:27: error: unknown type name 'size_t'
      24 |                            const u8 *cmd_data, size_t cmd_data_size);
         |                                                ^
>> drivers/nvmem/qnap-mcu-eeprom.c:28:10: error: call to undeclared function 'kzalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      28 |         reply = kzalloc(bytes + sizeof(cmd), GFP_KERNEL);
         |                 ^
>> drivers/nvmem/qnap-mcu-eeprom.c:28:8: error: incompatible integer to pointer conversion assigning to 'u8 *' (aka 'unsigned char *') from 'int' [-Wint-conversion]
      28 |         reply = kzalloc(bytes + sizeof(cmd), GFP_KERNEL);
         |               ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/nvmem/qnap-mcu-eeprom.c:45:2: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      45 |         kfree(reply);
         |         ^
   1 warning and 11 errors generated.


vim +/kzalloc +28 drivers/nvmem/qnap-mcu-eeprom.c

    20	
    21	static int qnap_mcu_eeprom_read_block(struct qnap_mcu *mcu, unsigned int offset,
    22					      void *val, size_t bytes)
    23	{
    24		const u8 cmd[] = { 0xf7, 0xa1, offset, bytes };
    25		u8 *reply;
    26		int ret = 0;
    27	
  > 28		reply = kzalloc(bytes + sizeof(cmd), GFP_KERNEL);
    29		if (!reply)
    30			return -ENOMEM;
    31	
    32		ret = qnap_mcu_exec(mcu, cmd, sizeof(cmd), reply, bytes + sizeof(cmd));
    33		if (ret)
    34			goto out;
    35	
    36		/* First bytes must mirror the sent command */
    37		if (memcmp(cmd, reply, sizeof(cmd))) {
    38			ret = -EIO;
    39			goto out;
    40		}
    41	
    42		memcpy(val, reply + sizeof(cmd), bytes);
    43	
    44	out:
  > 45		kfree(reply);
    46		return ret;
    47	}
    48	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki