linux-kernel - Re: [PATCH 2/3] pinctrl: use more common syntax for compound literals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MeR3iH7cH4aLuN5T+y5FCFyzpR3BBc4chE7CPAy8Ug2gQ@mail.gmail.com>
Date: Thu, 25 Sep 2025 10:11:52 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Lee Jones <lee@...nel.org>, Andy Shevchenko <andriy.shevchenko@...el.com>, 
	Liviu Dudau <liviu.dudau@....com>, Sudeep Holla <sudeep.holla@....com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Avi Fishman <avifishman70@...il.com>, 
	Tomer Maimon <tmaimon77@...il.com>, Tali Perry <tali.perry1@...il.com>, 
	Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>, 
	Benjamin Fair <benjaminfair@...gle.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Jonathan Neuschäfer <j.neuschaefer@....net>, 
	Clément Le Goffic <legoffic.clement@...il.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	James Cowgill <james.cowgill@...ize.com>, Matt Redfearn <matt.redfearn@...ize.com>, 
	Neil Jones <neil.jones@...ize.com>, 
	Nikolaos Pasaloukos <nikolaos.pasaloukos@...ize.com>, Hoan Tran <hoan@...amperecomputing.com>, 
	Yang Shen <shenyang39@...wei.com>, Imre Kaloz <kaloz@...nwrt.org>, 
	Yinbo Zhu <zhuyinbo@...ngson.cn>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Manivannan Sadhasivam <mani@...nel.org>, 
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	openbmc@...ts.ozlabs.org, linux-gpio@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, imx@...ts.linux.dev, 
	linux-unisoc@...ts.infradead.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/3] pinctrl: use more common syntax for compound literals

On Thu, Sep 25, 2025 at 10:03 AM Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>
> Hi Bartosz,
>
> On Thu, 25 Sept 2025 at 09:52, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > On Thu, Sep 25, 2025 at 9:48 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > > On Thu, 11 Sept 2025 at 12:02, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > > >
> > > > The (typeof(foo)) construct is unusual in the kernel, use a more typical
> > > > syntax by explicitly spelling out the type.
> > >
> > > Thanks for your patch, which is now commit da3a88e9656c17a3 ("pinctrl:
> > > use more common syntax for compound literals") in pinctrl/for-next
> > >
> > > > Link: https://lore.kernel.org/all/20250909-gpio-mmio-gpio-conv-part4-v1-13-9f723dc3524a@linaro.org/
>
> This is the origin link to the patch (by you) that started the discussion.
>
> > >
> > > Looks like you (slightly) missed your target. The correct link is:
> > >
> > >     Link: https://lore.kernel.org/aMAP9hAWars0T83r@smile.fi.intel.com
>
> This is the link to the comment (by Andy) that questioned the construct.
>
> > >
> > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > This is a link to the discussion with Andy as per Linus Torvalds'
> > recent request to use the Link: tag to point to actually useful
> > information rather than just the patch's origin. Linus Walleij doesn't
> > use b4 so the origin link you'd normally expect to be added
> > automatically is not there at all. That's probably what caused the
> > confusion.
>
> I know ;-)
>
> Given the "Suggested-by: Andy", shouldn't the link point to the email
> with the actual suggestion?
>

Ah, I didn't realize this is what you meant. I wanted to point to the
entire discussion and also this is already in Linus' tree so it's up
to him if he wants to change it.

Bartosz