linux-kernel - Re: [PATCH net-next v11 5/5] net: dsa: yt921x: Add support for Motorcomm YT921x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250924173551.2e09b168@kernel.org>
Date: Wed, 24 Sep 2025 17:35:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yangfl <mmyangfl@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Simon Horman <horms@...nel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v11 5/5] net: dsa: yt921x: Add support for
 Motorcomm YT921x

On Wed, 24 Sep 2025 20:33:57 +0800 Yangfl wrote:
> On Wed, Sep 24, 2025 at 8:47 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > > +             cancel_delayed_work_sync(&pp->mib_read);
> > > +     }
> > > +
> > > +     dsa_unregister_switch(&priv->ds);  
> >
> > The work canceling looks racy, the port can come up in between
> > cancel_work and dsa_unregister ? disable_delayed_work.. will likely
> > do the job.  
> 
> Are you sure about this? There are many others who use
> cancel_delayed_work_sync in their teardown methods (for example
> ar9331_sw_remove). If that is true, they should be fixed too.

Not at all! I'll gladly accept an explanation of why the code is
correct. "Someone else is doing it too" is not an explanation.