linux-kernel - Re: [PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNUcn7TxcnwG0OLw@shikoro>
Date: Thu, 25 Sep 2025 12:42:39 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header
 file

On Sun, Sep 07, 2025 at 12:03:44PM +0300, Cezar Chiru wrote:
> Fixed code indent should use tabs error, missing '*' from
> multiple line block comment warning, space prohibited after
> paranthesis error and no space before tabs warning.
> My motivation was to fix all errors and warnings in
> drivers/i2c/algos/i2c-algo-pcf.h file.
> 
> Testing:
>     * built kernel with my changes and I2C_ALGOPCF=m enabled
>     and it built successfully.
>     * installed kernel and external modules generated by build
>     * rebooted and loaded using modprobe i2c-algo-pcf kernel module
>     with param i2c_debug=3 and no message was found related to
>     module in dmesg. But also no error was generated.

Because these are only whitespace changes, the object file (.o) should
not have change after your change. You can check for that.

> -#define I2C_PCF_REPSTART (              I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
> +#define I2C_PCF_REPSTART	       (I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)

checkpatch is wrong here, this is less readable than before.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)