linux-kernel - Re: [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0dd6a528-d204-4073-a4b6-76356e71c5fc@oss.qualcomm.com>
Date: Thu, 25 Sep 2025 13:34:17 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Tingguo Cheng <tingguo.cheng@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@....qualcomm.com,
        Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>,
        Rakesh Kota <rakesh.kota@....qualcomm.com>
Subject: Re: [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc

On 9/25/25 9:48 AM, Tingguo Cheng wrote:
> Add RTC node, the RTC is controlled by PMIC device via spmi bus.

subject: "arm64: dts: qcom: lemans-pmics: foo"

(following the style for the directory)
> 
> Signed-off-by: Tingguo Cheng <tingguo.cheng@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..9e0d05c1b39ce229d5d4310ea1df1bf02e689178 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> @@ -132,6 +132,13 @@ pmm8654au_0_pon_resin: resin {
>  			};
>  		};
>  
> +		pmm8654au_0_rtc: rtc@...0 {
> +			compatible = "qcom,pmk8350-rtc";
> +			reg = <0x6100>, <0x6200>;
> +			reg-names = "rtc", "alarm";

1 reg and name a line, please

> +			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;

Do we not need "qcom,no-alarm" on lemans?

Konrad