linux-kernel - Re: [PATCH 3/3] crypto: qce: add support for QCE major version 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39f6f7af-4b0a-496f-9391-880932634551@oss.qualcomm.com>
Date: Thu, 25 Sep 2025 13:48:58 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
        trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com,
        Gaurav Kashyap <gaurav.kashyap@....qualcomm.com>
Subject: Re: [PATCH 3/3] crypto: qce: add support for QCE major version 6

On 9/25/25 1:38 AM, Jingyi Wang wrote:
> From: Gaurav Kashyap <gaurav.kashyap@....qualcomm.com>
> 
> The Qualcomm General Purpose Crypto Engine (GPCE) has
> upgraded to version 6 on newer socs, this makes the
> version check logic obsolete and needs to be updated
> to account for v6.0.
> 
> As part of this, unnecessary version macros has also
> been removed.
> 
> Signed-off-by: Gaurav Kashyap <gaurav.kashyap@....qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
> ---

This commit message does not reflect what the code does (or at
least it does so very indirectly)

You can instead title the commit message "fix version check" and
mention in the commit text that this is necessary e.g. for v6

Konrad