linux-kernel - Re: [PATCH 08/19] clk: divider: check divider validity for CLK_DIVIDER_EVEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6823295.MDQidcC6GM@benoit.monin>
Date: Thu, 25 Sep 2025 13:51:37 +0200
From: Benoît Monin <benoit.monin@...tlin.com>
To: Conor Dooley <conor+dt@...nel.org>,
 Gregory CLEMENT <gregory.clement@...tlin.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Michael Turquette <mturquette@...libre.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Théo Lebrun <theo.lebrun@...tlin.com>,
 Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
 Stephen Boyd <sboyd@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 Tawfik Bayouk <tawfik.bayouk@...ileye.com>,
 Sari Khoury <sari.khoury@...ileye.com>
Subject:
 Re: [PATCH 08/19] clk: divider: check divider validity for
 CLK_DIVIDER_EVEN_INTEGERS

On Saturday, 20 September 2025 at 07:15:45 CEST, Stephen Boyd wrote:
> Quoting Benoît Monin (2025-09-03 05:47:15)
> > Ensure that the divider is even when the flag CLK_DIVIDER_EVEN_INTEGERS
> > is set, similar to the power of two check for CLK_DIVIDER_POWER_OF_TWO.
> > 
> 
> Is this a fix?
> 
This was found during code review, nothing prevents divider_get_val() to
compute an odd divider, but we have not hit a bug caused by that.

Should I add a Fixes tag to 
6a136805e3c15 ("clk: divider: IntroduceCLK_DIVIDER_EVEN_INTEGERS flag")
or drop this patch since it does not fix a bug per se?

Best regards,
-- 
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com