| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b05e5979-2c62-4de5-ba29-e3b9e9167da8@iogearbox.net> Date: Thu, 25 Sep 2025 13:58:41 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>, andrii@...nel.org, eddyz87@...il.com, ast@...nel.org, martin.lau@...ux.dev, song@...nel.org, yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org, sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, shuah@...nel.org, matttbe@...nel.org, martineau@...nel.org, geliang@...nel.org, davem@...emloft.net, kuba@...nel.org, hawk@...nel.org, linux@...danrome.com, ameryhung@...il.com, toke@...hat.com, houtao1@...wei.com, emil@...alapatis.com, yatsenko@...a.com, isolodrai@...a.com, a.s.protopopov@...il.com, dxu@...uu.xyz, memxor@...il.com, vmalik@...hat.com, bigeasy@...utronix.de, tj@...nel.org, gregkh@...uxfoundation.org, paul@...l-moore.com, bboscaccy@...ux.microsoft.com, James.Bottomley@...senPartnership.com, mrpre@....com, jakub@...udflare.com Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, mptcp@...ts.linux.dev, linux-kernel-mentees@...ts.linuxfoundation.org, skhan@...uxfoundation.org, david.hunter.linux@...il.com Subject: Re: [PATCH bpf-next v2] selftests/bpf: Add -Wsign-compare C compilation flag On 9/24/25 9:57 PM, Mehdi Ben Hadj Khelifa wrote: > -Change all the source files and the corresponding headers > to having matching sign comparisons. > > Signed-off-by: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com> > --- > Changelog: > > Changes since v1: > - Fix CI failed builds where it failed due to do missing .c and > .h files in my patch for working in mainline. > https://lore.kernel.org/bpf/20250924162408.815137-1-mehdi.benhadjkhelifa@gmail.com/T/#u > --- > tools/lib/bpf/usdt.bpf.h | 4 ++-- > tools/testing/selftests/bpf/Makefile | 4 ++-- > tools/testing/selftests/bpf/bpf_arena_htab.h | 2 +- > tools/testing/selftests/bpf/progs/arena_list.c | 2 +- > .../bpf/progs/bench_local_storage_create.c | 2 +- > tools/testing/selftests/bpf/progs/bind_perm.c | 2 +- > tools/testing/selftests/bpf/progs/bpf_cc_cubic.c | 2 +- > tools/testing/selftests/bpf/progs/bpf_cubic.c | 8 ++++---- > .../bpf/progs/bpf_iter_bpf_percpu_array_map.c | 2 +- > .../selftests/bpf/progs/bpf_iter_task_stack.c | 2 +- > .../testing/selftests/bpf/progs/bpf_iter_tasks.c | 3 ++- > .../selftests/bpf/progs/bpf_iter_vma_offset.c | 4 ++-- > .../testing/selftests/bpf/progs/bpf_qdisc_fifo.c | 2 +- > tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c | 4 ++-- > .../bpf/progs/cgroup_getset_retval_getsockopt.c | 6 +++--- > .../selftests/bpf/progs/connect4_dropper.c | 2 +- > .../selftests/bpf/progs/cpumask_success.c | 4 ++-- > .../testing/selftests/bpf/progs/dynptr_success.c | 8 ++++---- > tools/testing/selftests/bpf/progs/iters.c | 16 ++++++++-------- > .../selftests/bpf/progs/kfunc_call_test.c | 2 +- > tools/testing/selftests/bpf/progs/linked_list.c | 10 +++++----- > tools/testing/selftests/bpf/progs/lsm.c | 2 +- > .../testing/selftests/bpf/progs/map_in_map_btf.c | 2 +- > tools/testing/selftests/bpf/progs/map_ptr_kern.c | 2 +- > .../selftests/bpf/progs/mmap_inner_array.c | 2 +- > .../testing/selftests/bpf/progs/mptcp_subflow.c | 2 +- > .../selftests/bpf/progs/netif_receive_skb.c | 4 ++-- > tools/testing/selftests/bpf/progs/profiler.inc.h | 6 +++--- > .../testing/selftests/bpf/progs/rcu_read_lock.c | 4 ++-- > .../bpf/progs/sk_storage_omem_uncharge.c | 6 +++--- > .../selftests/bpf/progs/sockopt_inherit.c | 4 ++-- > tools/testing/selftests/bpf/progs/sockopt_sk.c | 4 ++-- > tools/testing/selftests/bpf/progs/strobemeta.h | 2 +- > .../selftests/bpf/progs/task_local_data.bpf.h | 6 +++--- > .../selftests/bpf/progs/test_bpf_cookie.c | 2 +- > .../testing/selftests/bpf/progs/test_check_mtu.c | 4 ++-- > .../selftests/bpf/progs/test_core_extern.c | 2 +- > .../testing/selftests/bpf/progs/test_get_xattr.c | 4 ++-- > .../selftests/bpf/progs/test_global_func11.c | 2 +- > .../selftests/bpf/progs/test_global_func12.c | 2 +- > .../selftests/bpf/progs/test_global_func13.c | 2 +- > .../selftests/bpf/progs/test_global_func14.c | 2 +- > .../selftests/bpf/progs/test_global_func9.c | 2 +- > .../selftests/bpf/progs/test_lwt_seg6local.c | 4 ++-- > .../testing/selftests/bpf/progs/test_map_init.c | 2 +- > .../selftests/bpf/progs/test_parse_tcp_hdr_opt.c | 2 +- > .../bpf/progs/test_parse_tcp_hdr_opt_dynptr.c | 2 +- > .../selftests/bpf/progs/test_pkt_access.c | 6 +++--- > .../testing/selftests/bpf/progs/test_seg6_loop.c | 4 ++-- > tools/testing/selftests/bpf/progs/test_skb_ctx.c | 2 +- > .../testing/selftests/bpf/progs/test_snprintf.c | 2 +- > .../selftests/bpf/progs/test_sockmap_kern.h | 2 +- > .../selftests/bpf/progs/test_sockmap_strp.c | 2 +- > .../testing/selftests/bpf/progs/test_tc_tunnel.c | 2 +- > tools/testing/selftests/bpf/progs/test_xdp.c | 2 +- > .../selftests/bpf/progs/test_xdp_dynptr.c | 2 +- > .../testing/selftests/bpf/progs/test_xdp_loop.c | 2 +- > .../selftests/bpf/progs/test_xdp_noinline.c | 4 ++-- > tools/testing/selftests/bpf/progs/udp_limit.c | 2 +- > tools/testing/selftests/bpf/progs/uprobe_multi.c | 4 ++-- > .../bpf/progs/uprobe_multi_session_recursive.c | 5 +++-- > .../selftests/bpf/progs/verifier_arena_large.c | 4 ++-- > .../bpf/progs/verifier_iterating_callbacks.c | 2 +- > 63 files changed, 109 insertions(+), 107 deletions(-) Big churn all over the place :/ Either way, it looks like you haven't run the tests locally before submitting, some are failing: https://github.com/kernel-patches/bpf/actions/runs/17993782331
Powered by blists - more mailing lists