linux-kernel - Re: [PATCH][next][V2] drm/xe/xe_late_bind_fw: Fix missing initialization of variable offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19cadb88-1b80-444e-a062-54f3f42c856d@intel.com>
Date: Thu, 25 Sep 2025 17:34:49 +0530
From: "Nilawar, Badal" <badal.nilawar@...el.com>
To: Colin Ian King <colin.i.king@...il.com>, Lucas De Marchi
	<lucas.demarchi@...el.com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Daniele
 Ceraolo Spurio" <daniele.ceraolospurio@...el.com>,
	<intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next][V2] drm/xe/xe_late_bind_fw: Fix missing
 initialization of variable offset


On 24-09-2025 15:52, Colin Ian King wrote:
> The variable offset is not being initialized, and it is only set inside
> a for-loop if entry->name is the same as manifest_entry. In the case
> where it is not initialized a non-zero check on offset is potentialy checking
> a bogus uninitalized value. Fix this by initializing offset to zero.
>
> Fixes: efa29317a553 ("drm/xe/xe_late_bind_fw: Extract and print version info")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Reviewed-by: Badal Nilawar <badal.nilawar@...el.com>
> ---
>
> V2: Fix identical issue in parse_lb_layout that I ommitted in the first
> patch
>
> ---
>   drivers/gpu/drm/xe/xe_late_bind_fw.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 38f3feb2aecd..8f5082e689dc 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -60,7 +60,7 @@ static int parse_cpd_header(struct xe_late_bind_fw *lb_fw,
>   	const struct gsc_manifest_header *manifest;
>   	const struct gsc_cpd_entry *entry;
>   	size_t min_size = sizeof(*header);
> -	u32 offset;
> +	u32 offset = 0;
>   	int i;
>   
>   	/* manifest_entry is mandatory */
> @@ -116,7 +116,7 @@ static int parse_lb_layout(struct xe_late_bind_fw *lb_fw,
>   	const struct csc_fpt_header *header = data;
>   	const struct csc_fpt_entry *entry;
>   	size_t min_size = sizeof(*header);
> -	u32 offset;
> +	u32 offset = 0;
>   	int i;
>   
>   	/* fpt_entry is mandatory */