linux-kernel - Re: [PATCH 13/20] arm64: dts: qcom: kaanapali: Add QUPv3 configuration for serial engines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9685e29d-bff3-4188-b878-230d0f161ce3@oss.qualcomm.com>
Date: Thu, 25 Sep 2025 14:28:32 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, aiqun.yu@....qualcomm.com,
        tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com,
        yijie.yang@....qualcomm.com,
        Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
Subject: Re: [PATCH 13/20] arm64: dts: qcom: kaanapali: Add QUPv3
 configuration for serial engines

On 9/25/25 2:17 AM, Jingyi Wang wrote:
> From: Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
> 
> Add device tree support for QUPv3 serial engine protocols on Kaanapali.
> Kaanapali has 24 QUP serial engines across 4 QUP wrappers, each with
> support of GPI DMA engines, and it also includes 5 I2C hubs.
> 
> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
> Co-developed-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
> ---

[...]

> +		gpi_dma2: dma-controller@...000 {
> +			compatible = "qcom,kaanapali-gpi-dma", "qcom,sm6350-gpi-dma";
> +			reg = <0x0 0x00800000 0x0 0x60000>;
> +
> +			interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 848 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 849 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 850 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 851 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 852 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 853 IRQ_TYPE_LEVEL_HIGH>,
> +					<GIC_SPI 854 IRQ_TYPE_LEVEL_HIGH>;

odd indentation (on almost all gpi_dma instances)

[...]

> -		remoteproc_soccp: remoteproc-soccp@...000 {
> -			compatible = "qcom,kaanapali-soccp-pas";
> -			reg = <0x0 0x00d00000 0x0 0x200000>;
> +			i2c22: i2c@...c000 {
> +				compatible = "qcom,geni-i2c";
> +				reg = <0x0 0x01a8c000 0x0 0x4000>;
>  
> -			interrupts-extended = <&intc GIC_SPI 167 IRQ_TYPE_EDGE_RISING>,
> -					      <&soccp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> -					      <&soccp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> -					      <&soccp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> -					      <&soccp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
> -					      <&soccp_smp2p_in 9 IRQ_TYPE_EDGE_RISING>,
> -					      <&soccp_smp2p_in 10 IRQ_TYPE_EDGE_RISING>;
> -			interrupt-names = "wdog",
> -					  "fatal",
> -					  "ready",
> -					  "handover",
> -					  "stop-ack",
> -					  "pong",
> -					  "wake-ack";

Please try to use git format-patch --patience

Konrad