linux-kernel - Re: [PATCH 0/2] rust: usb: add initial USB abstractions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DE1DF8C3-B4D6-4392-A4A7-E324CFDCCD3A@collabora.com>
Date: Thu, 25 Sep 2025 14:58:30 +0200
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 linux-usb@...r.kernel.org
Subject: Re: [PATCH 0/2] rust: usb: add initial USB abstractions

Hi Greg,

> On 25 Sep 2025, at 14:52, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> On Mon, Aug 25, 2025 at 03:18:04PM -0300, Daniel Almeida wrote:
>> This adds initial support for USB Rust drivers, not only because I see a
>> widespread use of module_usb_driver() in media (which is a subsystem I
>> aim to support) but also because I want to learn about USB in general
>> and this is a nice opportunity to start doing so.
>> 
>> I tried to keep things as consistent with pci.rs and platform.rs as
>> possible and tested it by manually binding a device (i.e.: my Logitech
>> mouse) to the sample driver via:
>> 
>> /sys/bus/usb/drivers/rust_driver_usb/new_id
>> 
>> This initial patch is therefore comprised of the same patterns that are
>> known to work for pci and platform already.
>> 
>> Physically disconnecting the device also worked, i.e.: nothing bad
>> showed up in dmesg.
>> 
>> Note that I did not touch MAINTAINERS at all. The objective is to
>> kickstart the discussion of what to do there here in v1.
> 
> Ok, as this seems to now be at least building properly for me, I have
> taken it into my char-misc branch for the next -rc1 merge window.
> 
> BUT it has shown that it still needs some work to get "correct" and it
> really doesn't do much quite yet, so I have applied the patch below to
> pretty much just "disable" it entirely from the build at this point in
> time.
> 
> I'll go and revert this commit after -rc1 is out, in my usb-next branch,
> so that we can start to build on top of it and ensure that it doesn't
> break, but for 6.18, I don't think it's quite ready to be there.

Cool,

I’ll follow up with the fixes required, and slowly build the features
needed for usb-skeleton as we discussed.

Give me a couple of weeks though, I need to get myself out of conference
hell first :)

Btw, thanks for the reviews, Danilo!

— Daniel