linux-kernel - Re: [PATCH v3] net: wan: framer: Add version sysfs attribute for the Lantiq PEF2256 framer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250926133522.1b551382@kernel.org>
Date: Fri, 26 Sep 2025 13:35:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Herve Codina <herve.codina@...tlin.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: wan: framer: Add version sysfs attribute for
 the Lantiq PEF2256 framer

On Thu, 25 Sep 2025 09:06:13 +0200 Christophe Leroy wrote:
> Le 25/09/2025 à 01:48, Jakub Kicinski a écrit :
> > On Wed, 24 Sep 2025 17:06:47 +0200 Christophe Leroy wrote:  
> >> Lantiq PEF2256 framer has some little differences in behaviour
> >> depending on its version.
> >>
> >> Add a sysfs attribute to allow user applications to know the
> >> version.  
> > 
> > Outsider question perhaps but what is the version of?
> > It sounds like a HW revision but point releases for ASICs are quite
> > uncommon. So I suspect it's some SW/FW version?  
> 
> The datasheet of the component just calls it 'version'.
> 
> Among all registers there is a register called 'version status register' 
> which contains a single field named 'Version Number of chip'. This field 
> is an 8 bits value and the documentation tells that value 0x00 is 
> version 1.2, value 0x10 is version 2.1, etc...
> 
> > We generally recommend using devlink dev info for reporting all sort
> > of versions...  
> 
> Ok, I'll look at devlink. Based on the above, what type of 
> DEVLINK_INFO_VERSION_GENERIC_XXXX would you use here ?

That all sounds very mysterious. Maybe let's stick with sysfs if 
we don't really know the details and where to put the value..