linux-kernel - Re: [PATCH 2/3] regulator: max77675: Add MAX77675 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509270448.fUvCkHOA-lkp@intel.com>
Date: Sat, 27 Sep 2025 04:58:57 +0800
From: kernel test robot <lkp@...el.com>
To: Joan-Na-adi <joan.na.devcode@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, Mark Brown <broonie@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, Joan Na <joan.na@...log.com>
Subject: Re: [PATCH 2/3] regulator: max77675: Add MAX77675 regulator driver

Hi Joan-Na-adi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-regulator/for-next]
[also build test WARNING on robh/for-next linus/master v6.17-rc7 next-20250926]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Joan-Na-adi/dt-bindings-regulator-Add-MAX77675-binding-header/20250926-134116
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
patch link:    https://lore.kernel.org/r/20250926053757.480086-3-joan.na%40analog.com
patch subject: [PATCH 2/3] regulator: max77675: Add MAX77675 regulator driver
config: sparc-randconfig-r073-20250927 (https://download.01.org/0day-ci/archive/20250927/202509270448.fUvCkHOA-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250927/202509270448.fUvCkHOA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509270448.fUvCkHOA-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/regulator/max77675-regulator.c: In function 'max77675_set_sbb_slew_rate':
>> drivers/regulator/max77675-regulator.c:246:18: warning: variable 'value' set but not used [-Wunused-but-set-variable]
     246 |         u8 mask, value;
         |                  ^~~~~
   drivers/regulator/max77675-regulator.c: At top level:
   drivers/regulator/max77675-regulator.c:371:33: warning: initialized field overwritten [-Woverride-init]
     371 |         .list_voltage         = regulator_list_voltage_linear,
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/regulator/max77675-regulator.c:371:33: note: (near initialization for 'max77675_regulator_ops.list_voltage')


vim +/value +246 drivers/regulator/max77675-regulator.c

   231	
   232	/**
   233	 * max77675_set_sbb_slew_rate - Set the slew rate for a specific SBB regulator channel
   234	 *
   235	 * @maxreg: Pointer to the max77675 regulator structure
   236	 * @id: Regulator channel ID (ID_SBB0 ~ ID_SBB3)
   237	 * @val: Slew rate value (0 = 2mV/us, 1 = use DVS_SLEW)
   238	 *
   239	 * This function configures the slew rate control source for the specified SBB channel by
   240	 * updating the corresponding bits in the CNFG_SBB_TOP_B register.
   241	 *
   242	 * Return: 0 on success, negative error code on failure (e.g., invalid channel ID).
   243	 */
   244	static int max77675_set_sbb_slew_rate(struct max77675_regulator *maxreg, int id, u8 val)
   245	{
 > 246		u8 mask, value;
   247	
   248		switch (id) {
   249		case MAX77675_ID_SBB0:
   250			mask = MAX77675_SR_SBB0_BIT;
   251			value = FIELD_PREP(MAX77675_SR_SBB0_BIT, val);
   252			break;
   253	
   254		case MAX77675_ID_SBB1:
   255			mask = MAX77675_SR_SBB1_BIT;
   256			value = FIELD_PREP(MAX77675_SR_SBB1_BIT, val);
   257			break;
   258	
   259		case MAX77675_ID_SBB2:
   260			mask = MAX77675_SR_SBB2_BIT;
   261			value = FIELD_PREP(MAX77675_SR_SBB2_BIT, val);
   262			break;
   263	
   264		case MAX77675_ID_SBB3:
   265			mask = MAX77675_SR_SBB3_BIT;
   266			value = FIELD_PREP(MAX77675_SR_SBB3_BIT, val);
   267			break;
   268		default:
   269			return -EINVAL;
   270		}
   271	
   272		return regmap_update_bits(maxreg->regmap, MAX77675_REG_CNFG_SBB_TOP_B, mask, val);
   273	}
   274	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki