linux-kernel - Re: [PATCH 1/2] soc: qcom: ocmem: fix device leak on lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNcA2SCZMckYmZXb@redhat.com>
Date: Fri, 26 Sep 2025 17:08:41 -0400
From: Brian Masney <bmasney@...hat.com>
To: Johan Hovold <johan@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Miaoqian Lin <linmq006@...il.com>
Subject: Re: [PATCH 1/2] soc: qcom: ocmem: fix device leak on lookup

On Fri, Sep 26, 2025 at 04:35:10PM +0200, Johan Hovold wrote:
> Make sure to drop the reference taken to the ocmem platform device when
> looking up its driver data.
> 
> Note that holding a reference to a device does not prevent its driver
> data from going away so there is no point in keeping the reference.
> 
> Also note that commit 0ff027027e05 ("soc: qcom: ocmem: Fix missing
> put_device() call in of_get_ocmem") fixed the leak in a lookup error
> path, but the reference is still leaking on success.
> 
> Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
> Cc: stable@...r.kernel.org	# 5.5: 0ff027027e05
> Cc: Brian Masney <bmasney@...hat.com>
> Cc: Miaoqian Lin <linmq006@...il.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Brian Masney <bmasney@...hat.com>