| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202509260852.9BZHHRAh-lkp@intel.com>
Date: Fri, 26 Sep 2025 08:50:35 +0800
From: kernel test robot <lkp@...el.com>
To: Anjelique Melendez <anjelique.melendez@....qualcomm.com>,
heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org
Cc: oe-kbuild-all@...ts.linux.dev, lumag@...nel.org,
neil.armstrong@...aro.org, johan+linaro@...nel.org,
quic_bjorande@...cinc.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 2/2] usb: typec: ucsi_glink: Increase buffer size to
support UCSI v2
Hi Anjelique,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.17-rc7 next-20250925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Anjelique-Melendez/usb-typec-ucsi_glink-Update-request-response-buffers-to-be-packed/20250925-074205
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20250924232631.644234-3-anjelique.melendez%40oss.qualcomm.com
patch subject: [PATCH v4 2/2] usb: typec: ucsi_glink: Increase buffer size to support UCSI v2
config: i386-randconfig-061-20250926 (https://download.01.org/0day-ci/archive/20250926/202509260852.9BZHHRAh-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509260852.9BZHHRAh-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509260852.9BZHHRAh-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/usb/typec/ucsi/ucsi_glink.c:98:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] owner @@ got int @@
drivers/usb/typec/ucsi/ucsi_glink.c:98:23: sparse: expected restricted __le32 [usertype] owner
drivers/usb/typec/ucsi/ucsi_glink.c:98:23: sparse: got int
drivers/usb/typec/ucsi/ucsi_glink.c:99:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] type @@ got int @@
drivers/usb/typec/ucsi/ucsi_glink.c:99:22: sparse: expected restricted __le32 [usertype] type
drivers/usb/typec/ucsi/ucsi_glink.c:99:22: sparse: got int
drivers/usb/typec/ucsi/ucsi_glink.c:100:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] opcode @@ got int @@
drivers/usb/typec/ucsi/ucsi_glink.c:100:24: sparse: expected restricted __le32 [usertype] opcode
drivers/usb/typec/ucsi/ucsi_glink.c:100:24: sparse: got int
>> drivers/usb/typec/ucsi/ucsi_glink.c:152:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [usertype] owner @@ got int @@
drivers/usb/typec/ucsi/ucsi_glink.c:152:23: sparse: expected restricted __le32 [addressable] [usertype] owner
drivers/usb/typec/ucsi/ucsi_glink.c:152:23: sparse: got int
>> drivers/usb/typec/ucsi/ucsi_glink.c:153:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [usertype] type @@ got int @@
drivers/usb/typec/ucsi/ucsi_glink.c:153:22: sparse: expected restricted __le32 [addressable] [usertype] type
drivers/usb/typec/ucsi/ucsi_glink.c:153:22: sparse: got int
>> drivers/usb/typec/ucsi/ucsi_glink.c:154:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [usertype] opcode @@ got int @@
drivers/usb/typec/ucsi/ucsi_glink.c:154:24: sparse: expected restricted __le32 [addressable] [usertype] opcode
drivers/usb/typec/ucsi/ucsi_glink.c:154:24: sparse: got int
vim +152 drivers/usb/typec/ucsi/ucsi_glink.c
467399d989d799 Dmitry Baryshkov 2024-06-27 142
62b5412b1f4afa Neil Armstrong 2023-03-21 143 static int pmic_glink_ucsi_locked_write(struct pmic_glink_ucsi *ucsi, unsigned int offset,
62b5412b1f4afa Neil Armstrong 2023-03-21 144 const void *val, size_t val_len)
62b5412b1f4afa Neil Armstrong 2023-03-21 145 {
87289544ef0b29 Anjelique Melendez 2025-09-24 146 struct ucsi_v2_write_buf_req_msg req = {};
87289544ef0b29 Anjelique Melendez 2025-09-24 147 unsigned long left, max_buf_len;
87289544ef0b29 Anjelique Melendez 2025-09-24 148 size_t req_len;
62b5412b1f4afa Neil Armstrong 2023-03-21 149 int ret;
62b5412b1f4afa Neil Armstrong 2023-03-21 150
87289544ef0b29 Anjelique Melendez 2025-09-24 151 memset(&req, 0, sizeof(req));
62b5412b1f4afa Neil Armstrong 2023-03-21 @152 req.hdr.owner = PMIC_GLINK_OWNER_USBC;
62b5412b1f4afa Neil Armstrong 2023-03-21 @153 req.hdr.type = MSG_TYPE_REQ_RESP;
62b5412b1f4afa Neil Armstrong 2023-03-21 @154 req.hdr.opcode = UC_UCSI_WRITE_BUF_REQ;
87289544ef0b29 Anjelique Melendez 2025-09-24 155
87289544ef0b29 Anjelique Melendez 2025-09-24 156 if (ucsi->ucsi->version >= UCSI_VERSION_2_0) {
87289544ef0b29 Anjelique Melendez 2025-09-24 157 req_len = sizeof(struct ucsi_v2_write_buf_req_msg);
87289544ef0b29 Anjelique Melendez 2025-09-24 158 max_buf_len = UCSI_BUF_V2_SIZE;
87289544ef0b29 Anjelique Melendez 2025-09-24 159 } else if (ucsi->ucsi->version) {
87289544ef0b29 Anjelique Melendez 2025-09-24 160 req_len = sizeof(struct ucsi_v1_write_buf_req_msg);
87289544ef0b29 Anjelique Melendez 2025-09-24 161 max_buf_len = UCSI_BUF_V1_SIZE;
87289544ef0b29 Anjelique Melendez 2025-09-24 162 } else {
87289544ef0b29 Anjelique Melendez 2025-09-24 163 return -EINVAL;
87289544ef0b29 Anjelique Melendez 2025-09-24 164 }
87289544ef0b29 Anjelique Melendez 2025-09-24 165
87289544ef0b29 Anjelique Melendez 2025-09-24 166 if (offset + val_len > max_buf_len)
87289544ef0b29 Anjelique Melendez 2025-09-24 167 return -EINVAL;
87289544ef0b29 Anjelique Melendez 2025-09-24 168
62b5412b1f4afa Neil Armstrong 2023-03-21 169 memcpy(&req.buf[offset], val, val_len);
62b5412b1f4afa Neil Armstrong 2023-03-21 170
62b5412b1f4afa Neil Armstrong 2023-03-21 171 reinit_completion(&ucsi->write_ack);
62b5412b1f4afa Neil Armstrong 2023-03-21 172
87289544ef0b29 Anjelique Melendez 2025-09-24 173 ret = pmic_glink_send(ucsi->client, &req, req_len);
62b5412b1f4afa Neil Armstrong 2023-03-21 174 if (ret < 0) {
62b5412b1f4afa Neil Armstrong 2023-03-21 175 dev_err(ucsi->dev, "failed to send UCSI write request: %d\n", ret);
62b5412b1f4afa Neil Armstrong 2023-03-21 176 return ret;
62b5412b1f4afa Neil Armstrong 2023-03-21 177 }
62b5412b1f4afa Neil Armstrong 2023-03-21 178
62b5412b1f4afa Neil Armstrong 2023-03-21 179 left = wait_for_completion_timeout(&ucsi->write_ack, 5 * HZ);
62b5412b1f4afa Neil Armstrong 2023-03-21 180 if (!left) {
62b5412b1f4afa Neil Armstrong 2023-03-21 181 dev_err(ucsi->dev, "timeout waiting for UCSI write response\n");
62b5412b1f4afa Neil Armstrong 2023-03-21 182 return -ETIMEDOUT;
62b5412b1f4afa Neil Armstrong 2023-03-21 183 }
62b5412b1f4afa Neil Armstrong 2023-03-21 184
62b5412b1f4afa Neil Armstrong 2023-03-21 185 return 0;
62b5412b1f4afa Neil Armstrong 2023-03-21 186 }
62b5412b1f4afa Neil Armstrong 2023-03-21 187
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists