linux-kernel - Re: [PATCH RFC 0/4] Add XDP RX queue index metadata via kfuncs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNY1z1GId4_-F4Jg@lore-desk>
Date: Fri, 26 Sep 2025 08:42:23 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>
Cc: Stanislav Fomichev <stfomichev@...il.com>, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	donald.hunter@...il.com, andrew+netdev@...n.ch, ast@...nel.org,
	daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
	matttbe@...nel.org, chuck.lever@...cle.com, jdamato@...tly.com,
	skhawaja@...gle.com, dw@...idwei.uk, mkarsten@...terloo.ca,
	yoong.siang.song@...el.com, david.hunter.linux@...il.com,
	skhan@...uxfoundation.org, horms@...nel.org, sdf@...ichev.me,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	bpf@...r.kernel.org, linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH RFC 0/4] Add XDP RX queue index metadata via kfuncs

> On 9/24/25 11:31 PM, Stanislav Fomichev wrote:
> > On 09/24, Mehdi Ben Hadj Khelifa wrote:
> > > On 9/23/25 9:45 PM, Stanislav Fomichev wrote:
> > > > On 09/23, Mehdi Ben Hadj Khelifa wrote:
> > > > > ---
> > > > > Mehdi Ben Hadj Khelifa (4):
> > > > >     netlink: specs: Add XDP RX queue index to XDP metadata
> > > > >     net: xdp: Add xmo_rx_queue_index callback
> > > > >     uapi: netdev: Add XDP RX queue index metadata flags
> > > > >     net: veth: Implement RX queue index XDP hint
> > > > > 
> > > > >    Documentation/netlink/specs/netdev.yaml |  5 +++++
> > > > >    drivers/net/veth.c                      | 12 ++++++++++++
> > > > >    include/net/xdp.h                       |  5 +++++
> > > > >    include/uapi/linux/netdev.h             |  3 +++
> > > > >    net/core/xdp.c                          | 15 +++++++++++++++
> > > > >    tools/include/uapi/linux/netdev.h       |  3 +++
> > > > >    6 files changed, 43 insertions(+)
> > > > >    ---
> > > > >    base-commit: 07e27ad16399afcd693be20211b0dfae63e0615f
> > > > >    this is the commit of tag: v6.17-rc7 on the mainline.
> > > > >    This patch series is intended to make a base for setting
> > > > >    queue_index in the xdp_rxq_info struct in bpf/cpumap.c to
> > > > >    the right index. Although that part I still didn't figure
> > > > >    out yet,I m searching for my guidance to do that as well
> > > > >    as for the correctness of the patches in this series.
> > > 
> > > > 
> > I don't really understand what queue_index means for the cpu map. It is
> > a kernel thread doing work, there is no queue. Maybe whoever added
> > the todo can clarify?

Hi Mehdi,

IIRC it is the queue index of the NIC that received the packet from the wire.

Regards,
Lorenzo

> 
> Hi Lorenzo,
> Can you help us clarify the todo added in cpu_map_bpf_prog_run_xdp() in this
> commit:
> github.com/torvalds/linux/commit/9216477449f33cdbc9c9a99d49f500b7fbb81702 ?
> 
> Regards,
> Mehdi

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)