linux-kernel - Re: [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c915fe6-a6c4-4814-a7ba-8f9682775951@linaro.org>
Date: Fri, 26 Sep 2025 09:21:17 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Chen Ni <nichen@...as.ac.cn>, sre@...nel.org, hansg@...nel.org,
 ilpo.jarvinen@...ux.intel.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform: arm64: thinkpad-t14s-ec: Convert comma to
 semicolon

On 26/09/2025 02:43, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/platform/arm64/lenovo-thinkpad-t14s.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> index f721763e13cc..1d5d11adaf32 100644
> --- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> @@ -401,14 +401,14 @@ static int t14s_kbd_audio_led_probe(struct t14s_ec *ec)
>   	int ret;
>   
>   	ec->led_mic_mute.name = "platform::micmute";
> -	ec->led_mic_mute.max_brightness = 1,
> -	ec->led_mic_mute.default_trigger = "audio-micmute",
> +	ec->led_mic_mute.max_brightness = 1;
> +	ec->led_mic_mute.default_trigger = "audio-micmute";
>   	ec->led_mic_mute.brightness_set_blocking = t14s_mic_mute_led_set;
>   	ec->led_mic_mute.brightness_get = t14s_mic_mute_led_get;
>   
>   	ec->led_spk_mute.name = "platform::mute";
> -	ec->led_spk_mute.max_brightness = 1,
> -	ec->led_spk_mute.default_trigger = "audio-mute",
> +	ec->led_spk_mute.max_brightness = 1;
> +	ec->led_spk_mute.default_trigger = "audio-mute";
>   	ec->led_spk_mute.brightness_set_blocking = t14s_spk_mute_led_set;
>   	ec->led_spk_mute.brightness_get = t14s_spk_mute_led_get;
>   

This definitely deserves a Fixes tag.

Then add

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>