linux-kernel - [PATCH v2] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250926091302.817919-1-nichen@iscas.ac.cn>
Date: Fri, 26 Sep 2025 17:13:02 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: sre@...nel.org,
	hansg@...nel.org,
	ilpo.jarvinen@...ux.intel.com,
	bryan.odonoghue@...aro.org
Cc: platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH v2] platform: arm64: thinkpad-t14s-ec: Convert comma to semicolon

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Fixes: 27221f91b83f ("platform: arm64: thinkpad-t14s-ec: new driver")
Signed-off-by: Chen Ni <nichen@...as.ac.cn>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
---
Changelog:

v1 -> v2:

1. Add Fixes tag.
---
 drivers/platform/arm64/lenovo-thinkpad-t14s.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
index f721763e13cc..1d5d11adaf32 100644
--- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
+++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
@@ -401,14 +401,14 @@ static int t14s_kbd_audio_led_probe(struct t14s_ec *ec)
 	int ret;
 
 	ec->led_mic_mute.name = "platform::micmute";
-	ec->led_mic_mute.max_brightness = 1,
-	ec->led_mic_mute.default_trigger = "audio-micmute",
+	ec->led_mic_mute.max_brightness = 1;
+	ec->led_mic_mute.default_trigger = "audio-micmute";
 	ec->led_mic_mute.brightness_set_blocking = t14s_mic_mute_led_set;
 	ec->led_mic_mute.brightness_get = t14s_mic_mute_led_get;
 
 	ec->led_spk_mute.name = "platform::mute";
-	ec->led_spk_mute.max_brightness = 1,
-	ec->led_spk_mute.default_trigger = "audio-mute",
+	ec->led_spk_mute.max_brightness = 1;
+	ec->led_spk_mute.default_trigger = "audio-mute";
 	ec->led_spk_mute.brightness_set_blocking = t14s_spk_mute_led_set;
 	ec->led_spk_mute.brightness_get = t14s_spk_mute_led_get;
 
-- 
2.25.1