linux-kernel - Re: [Question] About unnecessary policy_has_boost_freq() calls in freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250926094533.542873-1-zhangzihuan@kylinos.cn>
Date: Fri, 26 Sep 2025 17:45:33 +0800
From: Zihuan Zhang <zhangzihuan@...inos.cn>
To: rafael@...nel.org
Cc: linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org,
	viresh.kumar@...aro.org,
	zhangzihuan@...inos.cn,
	zhenglifeng1@...wei.com
Subject: Re: [Question] About unnecessary policy_has_boost_freq() calls in freq_table.c

> First off, setting policy->boost_supported doesn't really belong to
> cpufreq_table_validate_and_sort(), so the idea of splitting it off
> that function sounds reasonable to me.
> 

Agreed.

> However, cpufreq_boost_set_sw() is used as a .set_boost() callback, so
> it gets called every time the "boost enabled" setting is changed.  It
> doesn't look like a good place for updating policy->boost_supported to
> me.

Got it, where would you suggest updating policy->boost_supported instead?

Thanks!