linux-kernel - Re: [PATCH net] vhost: vringh: Fix copy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNZiPbINQWoJA_-w@horms.kernel.org>
Date: Fri, 26 Sep 2025 10:51:57 +0100
From: Simon Horman <horms@...nel.org>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: linux-kernel@...r.kernel.org,
	zhang jiao <zhangjiao2@...s.chinamobile.com>,
	Jason Wang <jasowang@...hat.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	kvm@...r.kernel.org, virtualization@...ts.linux.dev,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] vhost: vringh: Fix copy_to_iter return value check

On Thu, Sep 25, 2025 at 02:04:08AM -0400, Michael S. Tsirkin wrote:
> The return value of copy_to_iter can't be negative, check whether the
> copied length is equal to the requested length instead of checking for
> negative values.
> 
> Cc: zhang jiao <zhangjiao2@...s.chinamobile.com>
> Link: https://lore.kernel.org/all/20250910091739.2999-1-zhangjiao2@cmss.chinamobile.com
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Hi Michael,

As a patch for net, I think it would be nice to include a fixes tag.
Perhaps:

Fixes: 309bba39c945 ("vringh: iterate on iotlb_translate to handle large translations")

And nicer still to include some description of the failure scenario.

In any case, the code change looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>