linux-kernel - Re: [PATCH v1] drm/panthor: skip regulator setup if no such prop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250926120311.33dc9fb1@fedora>
Date: Fri, 26 Sep 2025 12:03:11 +0200
From: Boris Brezillon <boris.brezillon@...labora.com>
To: Rain Yang <jiyu.yang@....nxp.com>
Cc: steven.price@....com, liviu.dudau@....com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.co, simona@...ll.ch, marek.vasut@...lbox.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, Rain Yang <jiyu.yang@....com>
Subject: Re: [PATCH v1] drm/panthor: skip regulator setup if no such prop

On Fri, 26 Sep 2025 17:07:22 +0800
Rain Yang <jiyu.yang@....nxp.com> wrote:

> From: Rain Yang <jiyu.yang@....com>
> 
> The regulator is optional, skip the setup instead of returning an
> error if it is not present

AFAICT, it's not flagged optional in the DT bindings yet, so I'd prefer
to have this change and the DT bindings update in the same patch series
(both will go through the drm-misc tree anway).

> 
> Signed-off-by: Rain Yang <jiyu.yang@....com>
> ---
>  drivers/gpu/drm/panthor/panthor_devfreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 3686515d368d..2df1d76d84a0 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -146,10 +146,9 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
>  	ptdev->devfreq = pdevfreq;
>  
>  	ret = devm_pm_opp_set_regulators(dev, reg_names);
> -	if (ret) {
> +	if (ret && ret != -ENODEV) {
>  		if (ret != -EPROBE_DEFER)
>  			DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n");
> -
>  		return ret;
>  	}
>