linux-kernel - Re: [PATCH] fix error code overwriting in smb2_get_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ef2a9a1-c1c6-42be-bfa8-65ce6a0a33d6@web.de>
Date: Fri, 26 Sep 2025 14:28:04 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Matvey Kovalev <matvey.kovalev@...ras.ru>, linux-cifs@...r.kernel.org,
 lvc-project@...uxtesting.org, Namjae Jeon <linkinjeon@...nel.org>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Sergey Senozhatsky <senozhatsky@...omium.org>,
 Steve French <smfrench@...il.com>, Tom Talpey <tom@...pey.com>
Subject: Re: [PATCH] fix error code overwriting in smb2_get_info_filesystem()

…
> ++ b/fs/smb/server/smb2pdu.c
> @@ -5628,7 +5628,8 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work,
>  
>  		if (!work->tcon->posix_extensions) {
>  			pr_err("client doesn't negotiate with SMB3.1.1 POSIX Extensions\n");
> -			rc = -EOPNOTSUPP;
> +			path_put(&path);
> +			return -EOPNOTSUPP;
>  		} else {
>  			info = (struct filesystem_posix_info *)(rsp->Buffer);
>  			info->OptimalTransferSize = cpu_to_le32(stfs.f_bsize);
…

How do you think about to avoid duplicate source code another bit?
https://elixir.bootlin.com/linux/v6.17-rc7/source/fs/smb/server/smb2pdu.c#L5437-L5653
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc7#n532

Would you like to choose a more appropriate subsystem specification?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc7#n646

Regards,
Markus