linux-kernel - Re: [PATCH v2 0/5] drm/solomon: Code improvements and DRM helper adoption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zfah8ie6.fsf@minerva.mail-host-address-is-not-set>
Date: Fri, 26 Sep 2025 15:15:13 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Iker Pedrosa <ikerpedrosam@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Iker
 Pedrosa <ikerpedrosam@...il.com>
Subject: Re: [PATCH v2 0/5] drm/solomon: Code improvements and DRM helper
 adoption

Iker Pedrosa <ikerpedrosam@...il.com> writes:

Hello Iker,

> This patch series improves the Solomon SSD130x DRM driver by adopting
> existing DRM helpers, improving code clarity, and following kernel
> coding standards.
>
> * Patch #1 moves DRM GEM framebuffer CPU access calls to make critical
>   sections more visible and maintainable.
> * Patch #2 replaces WARN_ON with drm_WARN_ON_ONCE to prevent log spam.
> * Patch #3 adopts drm_crtc_helper_mode_valid_fixed() for mode
>   validation.
> * Patch #4 adopts drm_connector_helper_get_modes_fixed() for mode
>   management.
> * Patch #5 enforces one assignment per line per kernel coding style.
>
> These improvements reduce code duplication by leveraging existing DRM
> infrastructure and enhance code readability without changing
> functionality.
>
> Signed-off-by: Iker Pedrosa <ikerpedrosam@...il.com>
> ---
> Changes in v2:
> - Use a goto label to ensure drm_dev_exit() is called in the error path
>   of drm_gem_fb_begin_cpu_access().
> - Link to v1: https://lore.kernel.org/r/20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com
>

Pushed to drm-misc (drm-misc-next). Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat