linux-kernel - Re: [PATCH] drivers/hwmon/pmbus: Add support for raa229141 in isl68137

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c29014bd-d441-4e4b-802a-7c6f5caf2cf5@roeck-us.net>
Date: Fri, 26 Sep 2025 06:24:39 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Jeff Lin <jefflin994697@...il.com>, jdelvare@...e.com
Cc: cedricjustine.encarnacion@...log.com, ninad@...ux.ibm.com,
 andriy.shevchenko@...ux.intel.com, johnerasmusmari.geronimo@...log.com,
 Mariel.Tinaco@...log.com, jbrunet@...libre.com, kimseer.paller@...log.com,
 leo.yang.sy0@...il.com, nuno.sa@...log.com, chiang.brian@...entec.com,
 gregkh@...uxfoundation.org, grantpeltier93@...il.com, peterz@...radead.org,
 william@...nnington.com, krzysztof.kozlowski@...aro.org, tzungbi@...nel.org,
 thorsten.blum@...ux.dev, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/hwmon/pmbus: Add support for raa229141 in
 isl68137

On 9/25/25 18:45, Jeff Lin wrote:
> In chip RAA229141 there exist ISYS pin which can report the current data
> for the device connected to this chip through this pin by routed by Direct
> Memory Access(DMA) command. To read the data in ISYS pin, we have to set
> the DMA address to 0xC5 and then read the DMA data from 0xC7. And then use
> the Direct read format with 10mA per LSB to transfer the data in 0xC7.
> And for ISYS input pin, the DMA address is 0xE0D3 and for ISYS output pin,
> the DMA address is 0xEE42.
> 
> Signed-off-by: Jeff Lin <jefflin994697@...il.com>
> ---
...
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index c52c55d2e7f4..04a582ba9416 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -63,6 +63,9 @@ enum chips {
>   	raa228228,
>   	raa229001,
>   	raa229004,
> ++#if IS_ENABLED(CONFIG_SENSORS_RAA229141)
> ++	raa229141,
> ++#endif /* CONFIG_SENSORS_RAA229141 */

I just realized (as did 0-day): This code doesn't even build.

Obviously that means that I can't trust that the code coming from you actually
works, even if it does build. Please keep that in mind if/when submitting
subsequent versions. I will want to see very detailed and verifiable
information about this chip and its supposed functionality.

Guenter