lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <76d9171c-4a74-499e-a598-ec51fdfa4e94@gaisler.com>
Date: Fri, 26 Sep 2025 15:53:52 +0200
From: Andreas Larsson <andreas@...sler.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Vincenzo Frascino <vincenzo.frascino@....com>, Arnd Bergmann
 <arnd@...db.de>, "David S. Miller" <davem@...emloft.net>,
 Nick Alcock <nick.alcock@...cle.com>, John Stultz <jstultz@...gle.com>,
 Stephen Boyd <sboyd@...nel.org>,
 John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
 Shuah Khan <shuah@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, Theodore Ts'o <tytso@....edu>,
 "Jason A. Donenfeld" <Jason@...c4.com>, Russell King
 <linux@...linux.org.uk>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>,
 Nagarathnam Muthusamy <nagarathnam.muthusamy@...cle.com>,
 Shannon Nelson <sln@...main.com>
Cc: linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org, loongarch@...ts.linux.dev,
 linux-mips@...r.kernel.org, linux-s390@...r.kernel.org,
 Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH v3 00/36] sparc64: vdso: Switch to the generic vDSO
 library

On 2025-09-17 16:00, Thomas Weißschuh wrote:
> The generic vDSO provides a lot common functionality shared between
> different architectures. SPARC is the last architecture not using it,
> preventing some necessary code cleanup.
> 
> Make use of the generic infrastructure.
> 
> Follow-up to and replacement for Arnd's SPARC vDSO removal patches:
> https://lore.kernel.org/lkml/20250707144726.4008707-1-arnd@kernel.org/
> 
> Tested on a Niagara T4 and QEMU.
> 
> This has a semantic conflict with my series "vdso: Reject absolute
> relocations during build". The last patch of this series expects all users
> of the generic vDSO library to use the vdsocheck tool.
> This is not the case (yet) for SPARC64. I do have the patches for the
> integration, the specifics will depend on which series is applied first.
> 
> Based on tip/timers/vdso.
> 
> [0] https://lore.kernel.org/lkml/20250812-vdso-absolute-reloc-v4-0-61a8b615e5ec@linutronix.de/
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
> Changes in v3:
> - Allocate vDSO data pages dynamically (and lots of preparations for that)
> - Drop clock_getres()
> - Fix 32bit clock_gettime() syscall fallback
> - Link to v2: https://lore.kernel.org/r/20250815-vdso-sparc64-generic-2-v2-0-b5ff80672347@linutronix.de
> 
> Changes in v2:
> - Rebase on v6.17-rc1
> - Drop RFC state
> - Fix typo in commit message
> - Drop duplicate 'select GENERIC_TIME_VSYSCALL'
> - Merge "sparc64: time: Remove architecture-specific clocksource data" into the
>   main conversion patch. It violated the check in __clocksource_register_scale()
> - Link to v1: https://lore.kernel.org/r/20250724-vdso-sparc64-generic-2-v1-0-e376a3bd24d1@linutronix.de
> 
> ---
> Arnd Bergmann (1):
>       clocksource: remove ARCH_CLOCKSOURCE_DATA
> 
> Thomas Weißschuh (35):
>       selftests: vDSO: vdso_test_correctness: Handle different tv_usec types
>       arm64: vDSO: getrandom: Explicitly include asm/alternative.h
>       arm64: vDSO: gettimeofday: Explicitly include vdso/clocksource.h
>       arm64: vDSO: compat_gettimeofday: Add explicit includes
>       ARM: vdso: gettimeofday: Add explicit includes
>       powerpc/vdso/gettimeofday: Explicitly include vdso/time32.h
>       powerpc/vdso: Explicitly include asm/cputable.h and asm/feature-fixups.h
>       LoongArch: vDSO: Explicitly include asm/vdso/vdso.h
>       MIPS: vdso: Add include guard to asm/vdso/vdso.h
>       MIPS: vdso: Explicitly include asm/vdso/vdso.h
>       random: vDSO: Add explicit includes
>       vdso/gettimeofday: Add explicit includes
>       vdso/helpers: Explicitly include vdso/processor.h
>       vdso/datapage: Remove inclusion of gettimeofday.h
>       vdso/datapage: Trim down unnecessary includes
>       random: vDSO: trim vDSO includes
>       random: vDSO: remove ifdeffery
>       random: vDSO: split out datapage update into helper functions
>       random: vDSO: only access vDSO datapage after random_init()
>       s390/time: Set up vDSO datapage later
>       vdso/datastore: Reduce scope of some variables in vvar_fault()
>       vdso/datastore: Drop inclusion of linux/mmap_lock.h
>       vdso/datastore: Map pages through struct page
>       vdso/datastore: Allocate data pages dynamically
>       sparc64: vdso: Link with -z noexecstack
>       sparc64: vdso: Remove obsolete "fake section table" reservation
>       sparc64: vdso: Replace code patching with runtime conditional
>       sparc64: vdso: Move hardware counter read into header
>       sparc64: vdso: Move syscall fallbacks into header
>       sparc64: vdso: Introduce vdso/processor.h
>       sparc64: vdso: Switch to the generic vDSO library
>       sparc64: vdso2c: Drop sym_vvar_start handling
>       sparc64: vdso2c: Remove symbol handling
>       sparc64: vdso: Implement clock_gettime64()
>       clocksource: drop include of asm/clocksource.h from linux/clocksource.h
> 
>  arch/arm/include/asm/vdso/gettimeofday.h           |   2 +
>  arch/arm64/include/asm/vdso/compat_gettimeofday.h  |   3 +
>  arch/arm64/include/asm/vdso/gettimeofday.h         |   2 +
>  arch/arm64/kernel/vdso/vgetrandom.c                |   2 +
>  arch/loongarch/kernel/process.c                    |   1 +
>  arch/loongarch/kernel/vdso.c                       |   1 +
>  arch/mips/include/asm/vdso/vdso.h                  |   5 +
>  arch/mips/kernel/vdso.c                            |   1 +
>  arch/powerpc/include/asm/vdso/gettimeofday.h       |   1 +
>  arch/powerpc/include/asm/vdso/processor.h          |   3 +
>  arch/s390/kernel/time.c                            |   4 +-
>  arch/sparc/Kconfig                                 |   3 +-
>  arch/sparc/include/asm/clocksource.h               |   9 -
>  arch/sparc/include/asm/processor.h                 |   3 +
>  arch/sparc/include/asm/processor_32.h              |   2 -
>  arch/sparc/include/asm/processor_64.h              |  25 --
>  arch/sparc/include/asm/vdso.h                      |   2 -
>  arch/sparc/include/asm/vdso/clocksource.h          |  10 +
>  arch/sparc/include/asm/vdso/gettimeofday.h         | 184 ++++++++++
>  arch/sparc/include/asm/vdso/processor.h            |  41 +++
>  arch/sparc/include/asm/vdso/vsyscall.h             |  10 +
>  arch/sparc/include/asm/vvar.h                      |  75 ----
>  arch/sparc/kernel/Makefile                         |   1 -
>  arch/sparc/kernel/time_64.c                        |   6 +-
>  arch/sparc/kernel/vdso.c                           |  69 ----
>  arch/sparc/vdso/Makefile                           |   8 +-
>  arch/sparc/vdso/vclock_gettime.c                   | 380 ++-------------------
>  arch/sparc/vdso/vdso-layout.lds.S                  |  26 +-
>  arch/sparc/vdso/vdso.lds.S                         |   2 -
>  arch/sparc/vdso/vdso2c.c                           |  24 --
>  arch/sparc/vdso/vdso2c.h                           |  45 +--
>  arch/sparc/vdso/vdso32/vdso32.lds.S                |   4 +-
>  arch/sparc/vdso/vma.c                              | 274 +--------------
>  drivers/char/random.c                              |  75 ++--
>  include/linux/clocksource.h                        |   8 -
>  include/linux/vdso_datastore.h                     |   6 +
>  include/vdso/datapage.h                            |  23 +-
>  include/vdso/helpers.h                             |   1 +
>  init/main.c                                        |   2 +
>  kernel/time/Kconfig                                |   4 -
>  lib/vdso/datastore.c                               |  73 ++--
>  lib/vdso/getrandom.c                               |   3 +
>  lib/vdso/gettimeofday.c                            |  17 +
>  .../testing/selftests/vDSO/vdso_test_correctness.c |   8 +-
>  44 files changed, 451 insertions(+), 997 deletions(-)
> ---
> base-commit: 5f84f6004e298bd41c9e4ed45c18447954b1dce6
> change-id: 20250722-vdso-sparc64-generic-2-25f2e058e92c

Tested-by: Andreas Larsson <andreas@...sler.com>
Reviewed-by: Andreas Larsson <andreas@...sler.com>
Acked-by: Andreas Larsson <andreas@...sler.com> # arch/sparc

Thanks,
Andreas


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ