linux-kernel - Re: [PATCH v5 3/6] vduse: add vq group support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250926112622-mutt-send-email-mst@kernel.org>
Date: Fri, 26 Sep 2025 11:26:56 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Eugenio Pérez <eperezma@...hat.com>
Cc: Yongji Xie <xieyongji@...edance.com>, linux-kernel@...r.kernel.org,
	Maxime Coquelin <mcoqueli@...hat.com>,
	Stefano Garzarella <sgarzare@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Cindy Lu <lulu@...hat.com>,
	virtualization@...ts.linux.dev, Laurent Vivier <lvivier@...hat.com>,
	jasowang@...hat.com
Subject: Re: [PATCH v5 3/6] vduse: add vq group support

On Fri, Sep 26, 2025 at 12:14:29PM +0200, Eugenio Pérez wrote:
> @@ -1859,6 +1894,7 @@ static int vduse_create_dev(struct vduse_dev_config *config,
>  	dev->device_features = config->features;
>  	dev->device_id = config->device_id;
>  	dev->vendor_id = config->vendor_id;
> +	dev->ngroups = (dev->api_version < 1) ? 1 : config->ngroups;

Is this < 1 same as VDUSE_API_VERSION_1? If so, maybe use that?