linux-kernel - Re: [PATCH v4 4/9] dt-bindings: mmc: Add Black Sesame Technologies DWCMSHC SDHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250926030608.2951582-1-yangzh0906@thundersoft.com>
Date: Fri, 26 Sep 2025 11:06:08 +0800
From: Albert Yang <yangzh0906@...ndersoft.com>
To: robh@...nel.org
Cc: adrian.hunter@...el.com,
	arnd@...db.de,
	bst-upstream@...ai.top,
	catalin.marinas@....com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	gordon.ge@....ai,
	krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	ulf.hansson@...aro.org,
	will@...nel.org,
	yangzh0906@...ndersoft.com
Subject: Re: [PATCH v4 4/9] dt-bindings: mmc: Add Black Sesame Technologies DWCMSHC SDHCI

On Tue, Sep 23, 2025 at 08:56:20AM -0500, Rob Herring wrote:
> On Tue, Sep 23, 2025 at 02:10:10PM +0800, Albert Yang wrote:
> > Add device tree binding documentation for the Black Sesame Technologies
> > (BST) DWCMSHC SDHCI controller.

Hi Rob,

Thanks for the review.

> Thanks for the changelog here, but the subject should have 'PATCH v4' so
> various tools work.

Understood. Will ensure v5 has the proper subject format with 'PATCH v5'.

> Filename should match compatible.

Fixed. Renamed from bst,dwcmshc-sdhci.yaml to bst,c1200-dwcmshc.yaml 
to match the compatible string "bst,c1200-dwcmshc", and updated the 
$id field accordingly.

> Not really any point in having -names when there is only 1 entry.

Agreed. I've dropped clock-names from the schema, DTS, and removed it 
from required properties.

> Having this is odd. Please add a description saying what it is for.

Added description for memory-region: "Reserved memory region for bounce 
buffer. Required due to controller's 32-bit DMA limitation while system 
RAM is above 32-bit addressable range."

Updated example:

    mmc@...00000 {
        compatible = "bst,c1200-dwcmshc";
        reg = <0x0 0x22200000 0x0 0x1000>,
              <0x0 0x23006000 0x0 0x1000>;
        interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
        clocks = <&clk_mmc>;
        memory-region = <&mmc0_reserved>;
        max-frequency = <200000000>;
        bus-width = <8>;
        non-removable;
        dma-coherent;
    };

Please let me know if you have any other concerns or suggestions for 
this binding. I'll send v5 with these fixes.

Thanks,
Albert Yang