linux-kernel - Re: [PATCH 13/15] serial: sc16is7xx: change incorrect indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250926121108.2e1c26b9acd140f5ede5b2a1@hugovil.com>
Date: Fri, 26 Sep 2025 12:11:08 -0400
From: Hugo Villeneuve <hugo@...ovil.com>
To: Maarten Brock <Maarten.Brock@...ls.nl>
Cc: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 "jirislaby@...nel.org" <jirislaby@...nel.org>, "fvallee@...rea.fr"
 <fvallee@...rea.fr>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "linux-serial@...r.kernel.org"
 <linux-serial@...r.kernel.org>, Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH 13/15] serial: sc16is7xx: change incorrect indentation

Hi Maarten,

On Fri, 26 Sep 2025 09:18:38 +0000
Maarten Brock <Maarten.Brock@...ls.nl> wrote:

> Hi Hugo,
> 
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > 
> > Change incorrect indentation level introduced in commit 9eb90d57b55a
> > ("sc16is7xx: Add flag to activate IrDA mode").
> 
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -1181,7 +1181,7 @@ static int sc16is7xx_startup(struct uart_port *port)
> >  	sc16is7xx_port_update(port, SC16IS7XX_MCR_REG,
> >  			      SC16IS7XX_MCR_IRDA_BIT,
> >  			      one->irda_mode ?
> > -				SC16IS7XX_MCR_IRDA_BIT : 0);
> > +			      SC16IS7XX_MCR_IRDA_BIT : 0);
> 
> Are you sure you want to unindent this?
> To me it now looks as if both "one->irda_mode" and "SC16IS7XX_MCR_IRDA_BIT : 0" are parameters.
> And why not fix this by placing both on one line? Is 76 characters already over the line length limit?

Excellent suggestion, will look much better. Will do it in V2.

-- 
Hugo Villeneuve